From: Changbin Du <changbin.du@gmail.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Changbin Du <changbin.du@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Quentin Monnet <quentin@isovalent.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Shuah Khan <shuah@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Mykola Lysenko <mykolal@fb.com>,
linux-perf-users@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v3 2/2] bpf: makefiles: do not generate empty vmlinux.h
Date: Tue, 20 Dec 2022 09:26:47 +0800 [thread overview]
Message-ID: <20221220012647.oytzq7q6ahwfhdow@mail.google.com> (raw)
In-Reply-To: <Y5/hqqIwJIjdBSRh@leoy-yangtze.lan>
On Mon, Dec 19, 2022 at 11:59:38AM +0800, Leo Yan wrote:
> On Sun, Dec 18, 2022 at 06:35:09AM +0800, Changbin Du wrote:
> > Remove the empty vmlinux.h if bpftool failed to dump btf info.
> > The empty vmlinux.h can hide real error when reading output
> > of make.
> >
> > This is done by adding .DELETE_ON_ERROR special target in related
> > makefiles.
>
> We need to handle the same case for perf building, its makefile
> linux/tools/perf/Makefile.perf also uses bpftool to generate
> vmlinux.h, see:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/Makefile.perf#n1067
>
> Please consider to use a separate patch to add the same change in
> Makefile.perf?
>
It's alreay there.
https://lore.kernel.org/lkml/20221217225151.90387-1-changbin.du@gmail.com/T/
> Thanks,
> Leo
>
> > Signed-off-by: Changbin Du <changbin.du@gmail.com>
> > ---
> > tools/bpf/bpftool/Makefile | 3 +++
> > tools/testing/selftests/bpf/Makefile | 3 +++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
> > index 787b857d3fb5..313fd1b09189 100644
> > --- a/tools/bpf/bpftool/Makefile
> > +++ b/tools/bpf/bpftool/Makefile
> > @@ -289,3 +289,6 @@ FORCE:
> > .PHONY: all FORCE bootstrap clean install-bin install uninstall
> > .PHONY: doc doc-clean doc-install doc-uninstall
> > .DEFAULT_GOAL := all
> > +
> > +# Delete partially updated (corrupted) files on error
> > +.DELETE_ON_ERROR:
> > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> > index c22c43bbee19..205e8c3c346a 100644
> > --- a/tools/testing/selftests/bpf/Makefile
> > +++ b/tools/testing/selftests/bpf/Makefile
> > @@ -626,3 +626,6 @@ EXTRA_CLEAN := $(TEST_CUSTOM_PROGS) $(SCRATCH_DIR) $(HOST_SCRATCH_DIR) \
> > liburandom_read.so)
> >
> > .PHONY: docs docs-clean
> > +
> > +# Delete partially updated (corrupted) files on error
> > +.DELETE_ON_ERROR:
> > --
> > 2.37.2
> >
--
Cheers,
Changbin Du
next prev parent reply other threads:[~2022-12-20 1:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 22:35 [PATCH v3 0/2] bpftool: improve error handing for missing .BTF section Changbin Du
2022-12-17 22:35 ` [PATCH v3 1/2] libbpf: show error info about missing ".BTF" section Changbin Du
2022-12-19 3:45 ` Leo Yan
2022-12-20 1:31 ` Changbin Du
2022-12-20 11:34 ` Leo Yan
2022-12-21 0:13 ` Andrii Nakryiko
2022-12-21 3:55 ` Leo Yan
2022-12-22 18:51 ` Andrii Nakryiko
2022-12-30 12:10 ` Changbin Du
2022-12-30 12:28 ` Leo Yan
2023-01-03 15:03 ` Quentin Monnet
2023-01-03 23:46 ` Andrii Nakryiko
2023-01-05 14:57 ` Quentin Monnet
2022-12-17 22:35 ` [PATCH v3 2/2] bpf: makefiles: do not generate empty vmlinux.h Changbin Du
2022-12-19 3:59 ` Leo Yan
2022-12-20 1:26 ` Changbin Du [this message]
2022-12-20 15:38 ` Quentin Monnet
2022-12-21 0:20 ` [PATCH v3 0/2] bpftool: improve error handing for missing .BTF section patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220012647.oytzq7q6ahwfhdow@mail.google.com \
--to=changbin.du@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=mingo@redhat.com \
--cc=mykolal@fb.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®