mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: torvalds@linux-foundation.org
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, rcu@vger.kernel.org, kernel-team@fb.com,
	rostedt@goodmis.org
Subject: [GIT PULL] Avoid synchronize_rcu() false positives in semi-early boot
Date: Mon, 19 Dec 2022 17:29:06 -0800	[thread overview]
Message-ID: <20221220012906.GA3102709@paulmck-ThinkPad-P17-Gen-1> (raw)

Hello, Linus,

Another merge window, another fix for another regression noted by Steve
Rostedt.  In the true spirit of closing the barn door after the horse
has escaped, the following commit is queued on -rcu to detect this sort
of bug in the future:

f13c14392ebc ("rcu: Test synchronous RCU grace periods at the end of rcu_init()")

The fix simply avoids consulting lockdep about interrupts-disabled
state before the scheduler has been initialized.  After all, before that
time, it is perfectly legal to invoke synchronize_rcu() with interrupts
disabled.

The following changes since commit 31d8aaa87fcef1be5932f3813ea369e21bd3b11d:

  rcu: Keep synchronize_rcu() from enabling irqs in early boot (2022-10-20 15:34:49 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git tags/rcu-urgent.2022.12.17a

for you to fetch changes up to 3f6c3d29df58f391cf487b50a24ebd24045ba569:

  rcu: Don't assert interrupts enabled too early in boot (2022-12-17 16:12:20 -0800)

----------------------------------------------------------------
Urgent RCU pull request for v6.2

This commit fixes a lockdep false positive in synchronize_rcu() that
can otherwise occur during early boot.  Theis fix simply avoids invoking
lockdep if the scheduler has not yet been initialized, that is, during
that portion of boot when interrupts are disabled.

----------------------------------------------------------------
Paul E. McKenney (1):
      rcu: Don't assert interrupts enabled too early in boot

 kernel/rcu/tree.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

             reply	other threads:[~2022-12-20  1:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20  1:29 Paul E. McKenney [this message]
2022-12-21 17:18 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221220012906.GA3102709@paulmck-ThinkPad-P17-Gen-1 \
    --to=paulmck@kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®