From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2415EC4332F for ; Tue, 20 Dec 2022 22:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233890AbiLTW2r (ORCPT ); Tue, 20 Dec 2022 17:28:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229943AbiLTW2p (ORCPT ); Tue, 20 Dec 2022 17:28:45 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D102B4B0 for ; Tue, 20 Dec 2022 14:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671575324; x=1703111324; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=HvkRqojfi6ClONQSzxg0z+qJIiMeSeXELz4Q5owrY9g=; b=IXPOz0Z+Ij1+GCBz2US5QOPMYG3vrInssXbNfpc1SpllF39ZuURJy38S +9EQuAfSwmm/TbPE6BEHPqDxQjRtl/hBTs2lIDHpt9Pfi5/GS3suOC20S yR7oT56QpQo/NNG+gTUFr2Zz4VQCRbupVX0eRwGQglfzpIGnCtDjT9Wqu a19Yp2R4heNWKI1q1BQec64RF56z87gUtRA396Sr/s177OwAsTyj3XrXI q24iqCEibm7cRsjhzJin4cxzNlKU6nWiDIYjXQHyo2nCmP87MR57IKPXk JHvQiJcQGMHt3GqwzBVBkRPPKztTQCTqqYDghpi0TK5DbfJ+gxKQBNuVT Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="317368989" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="317368989" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 14:28:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="825434877" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="825434877" Received: from uhpatel-desk4.jf.intel.com ([10.23.15.157]) by orsmga005.jf.intel.com with ESMTP; 20 Dec 2022 14:28:43 -0800 From: Utkarsh Patel To: mika.westerberg@linux.intel.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.or Cc: rajmohan.mani@intel.com, Utkarsh Patel Subject: [PATCH] thunderbolt: Do not report errors if on-board retimers are found Date: Tue, 20 Dec 2022 14:29:12 -0800 Message-Id: <20221220222912.3145485-1-utkarsh.h.patel@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tb_retimer_scan() returns error even when on-board retimers are found. Fixes: 1e56c88adecc ("thunderbolt: Runtime resume USB4 port when retimers are scanned") Signed-off-by: Utkarsh Patel --- drivers/thunderbolt/retimer.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/thunderbolt/retimer.c b/drivers/thunderbolt/retimer.c index 81252e31014a..6ebe7a2886ec 100644 --- a/drivers/thunderbolt/retimer.c +++ b/drivers/thunderbolt/retimer.c @@ -471,10 +471,9 @@ int tb_retimer_scan(struct tb_port *port, bool add) break; } - if (!last_idx) { - ret = 0; + ret = 0; + if (!last_idx) goto out; - } /* Add on-board retimers if they do not exist already */ for (i = 1; i <= last_idx; i++) { -- 2.25.1