From: Utkarsh Patel <utkarsh.h.patel@intel.com>
To: mika.westerberg@linux.intel.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Cc: rajmohan.mani@intel.com, Utkarsh Patel <utkarsh.h.patel@intel.com>
Subject: [PATCH] thunderbolt: Do not report errors if on-board retimers are found
Date: Tue, 20 Dec 2022 14:30:06 -0800 [thread overview]
Message-ID: <20221220223006.3145568-1-utkarsh.h.patel@intel.com> (raw)
tb_retimer_scan() returns error even when on-board retimers are found.
Fixes: 1e56c88adecc ("thunderbolt: Runtime resume USB4 port when retimers are scanned")
Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
---
drivers/thunderbolt/retimer.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/thunderbolt/retimer.c b/drivers/thunderbolt/retimer.c
index 81252e31014a..6ebe7a2886ec 100644
--- a/drivers/thunderbolt/retimer.c
+++ b/drivers/thunderbolt/retimer.c
@@ -471,10 +471,9 @@ int tb_retimer_scan(struct tb_port *port, bool add)
break;
}
- if (!last_idx) {
- ret = 0;
+ ret = 0;
+ if (!last_idx)
goto out;
- }
/* Add on-board retimers if they do not exist already */
for (i = 1; i <= last_idx; i++) {
--
2.25.1
next reply other threads:[~2022-12-20 22:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 22:30 Utkarsh Patel [this message]
2022-12-21 6:50 ` Greg KH
2022-12-22 6:14 ` Patel, Utkarsh H
-- strict thread matches above, loose matches on Subject: below --
2022-12-20 22:29 Utkarsh Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220223006.3145568-1-utkarsh.h.patel@intel.com \
--to=utkarsh.h.patel@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rajmohan.mani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®