From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DCEC001B2 for ; Thu, 22 Dec 2022 06:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235058AbiLVGOF (ORCPT ); Thu, 22 Dec 2022 01:14:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235054AbiLVGN5 (ORCPT ); Thu, 22 Dec 2022 01:13:57 -0500 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13C6F1AF24 for ; Wed, 21 Dec 2022 22:13:56 -0800 (PST) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-3bd1ff8fadfso11243027b3.18 for ; Wed, 21 Dec 2022 22:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=sXO+2cqQ2jD3iajPKrzJ7z5yUSuuXzzA/96bixg+F2U=; b=RBzamxSflqz2dnljq8hzGh3K+g7vkV1vpSKFgX6w0JKOg9dUn+Y/WaXJu3DhtVpjuo ALtRZuX1WGVCUNKcpQ3ANWhiGUz73vxYXlmH6StTQnmI8CrYeQDhkLQrIhhy4L47n2hZ X4GN5QLqu301t7NXd8ZZpuBpYYhdqKGubvs5RiZsiQomDETrdTXahMnqZnQFGRqYlgNu im+/kRLg+lX53aiiY4oJwMmfNcEVi2vRTWLGHxJsAwH1UG3k0W10/QMGtsfXREIzH0wH htZIoSXJwK1BlJe4S7NeMCg4ED/HaIuuROna1LPz5R7n+77MkBDwjj6lUVA4LWn//7xl EAbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sXO+2cqQ2jD3iajPKrzJ7z5yUSuuXzzA/96bixg+F2U=; b=Za/GqQrQV8t9kJmbf3k0bcFSkucovq3E8B1DHgjsHDiEqUwwC3RxflbdzgrnpBrINy TGYrmCaKUM9V4iRC9EVJH+UbQxae+iOq6JLc3Z/uiSuaQAnMfn6ZYPsb14a7L+41620V nJg9DavF7bfyNE6bbnTXO8vdJNYP3x94WLeIOqZfGMc2/w+HU5J7914fwTOuSuCO+SWq Q7mlHPwPoO0gnLDgUdinVJFZ3/9TsVm89s/YtfGBmBKI5RR4lZ7nDK6Gp5bi+Okg3pi1 qO1tRVJH5AyjYxxKg1+fBU3LynbCm3zhxoQ7+/8CM7OQpKy9SKNtSRwRSt86Xkv3qowe GcqQ== X-Gm-Message-State: AFqh2kps7UOWEp8fEnt7rlZyZlm/CETpoiA0mdmvsySB4EnbdpuvPNni yG7B9nc0Qsa0kKPaYQN5Lie3WjEk6qZ7 X-Google-Smtp-Source: AMrXdXubpzMCVNxT2q9xbikXo1M/LUPkX3kF0KVqtXoPwmraEpRHv+a8w7/K7YmvnJDVJVUEAX/Ko3eLEoOT X-Received: from yuanchu.svl.corp.google.com ([2620:15c:2d4:203:bd6e:5c67:5831:adad]) (user=yuanchu job=sendgmr) by 2002:a25:6d56:0:b0:6fa:c7e7:a572 with SMTP id i83-20020a256d56000000b006fac7e7a572mr479654ybc.456.1671689635274; Wed, 21 Dec 2022 22:13:55 -0800 (PST) Date: Wed, 21 Dec 2022 22:13:41 -0800 In-Reply-To: <20221222061341.381903-1-yuanchu@google.com> Mime-Version: 1.0 References: <20221222061341.381903-1-yuanchu@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20221222061341.381903-2-yuanchu@google.com> Subject: [PATCH 2/2] mm: support POSIX_FADV_NOREUSE for generic fadvise handler From: Yuanchu Xie To: Ivan Babrou , Johannes Weiner , Yu Zhao Cc: Alexander Viro , Andrew Morton , Steven Barrett , Brian Geffon , Oleksandr Natalenko , Suren Baghdasaryan , Arnd Bergmann , Peter Xu , Hugh Dickins , Gaosheng Cui , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yuanchu Xie Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yu Zhao POSIX_FADV_NOREUSE allows an application to specify that accesses to file data does not follow LRU and is used only once. Since 2.6.18 this is a no-op. We add FMODE_NOREUSE, checked in vma_has_locality to prevent LRU activation. Signed-off-by: Yu Zhao Signed-off-by: Yuanchu Xie --- include/linux/fs.h | 2 ++ include/linux/mm_inline.h | 3 +++ mm/fadvise.c | 5 ++++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 066555ad1bf8..5660ed0edf1a 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -166,6 +166,8 @@ typedef int (dio_iodone_t)(struct kiocb *iocb, loff_t offset, /* File supports DIRECT IO */ #define FMODE_CAN_ODIRECT ((__force fmode_t)0x400000) +#define FMODE_NOREUSE ((__force fmode_t)0x800000) + /* File was opened by fanotify and shouldn't generate fanotify events */ #define FMODE_NONOTIFY ((__force fmode_t)0x4000000) diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h index 80c0f6901ead..024f834d952d 100644 --- a/include/linux/mm_inline.h +++ b/include/linux/mm_inline.h @@ -583,6 +583,9 @@ static inline bool vma_has_locality(struct vm_area_struct *vma) if (vma->vm_flags & (VM_SEQ_READ | VM_RAND_READ)) return false; + if (vma->vm_file && (vma->vm_file->f_mode & FMODE_NOREUSE)) + return false; + return true; } diff --git a/mm/fadvise.c b/mm/fadvise.c index bf04fec87f35..fb7c5f43fd2a 100644 --- a/mm/fadvise.c +++ b/mm/fadvise.c @@ -80,7 +80,7 @@ int generic_fadvise(struct file *file, loff_t offset, loff_t len, int advice) case POSIX_FADV_NORMAL: file->f_ra.ra_pages = bdi->ra_pages; spin_lock(&file->f_lock); - file->f_mode &= ~FMODE_RANDOM; + file->f_mode &= ~(FMODE_RANDOM | FMODE_NOREUSE); spin_unlock(&file->f_lock); break; case POSIX_FADV_RANDOM: @@ -107,6 +107,9 @@ int generic_fadvise(struct file *file, loff_t offset, loff_t len, int advice) force_page_cache_readahead(mapping, file, start_index, nrpages); break; case POSIX_FADV_NOREUSE: + spin_lock(&file->f_lock); + file->f_mode |= FMODE_NOREUSE; + spin_unlock(&file->f_lock); break; case POSIX_FADV_DONTNEED: __filemap_fdatawrite_range(mapping, offset, endbyte, -- 2.39.0.314.g84b9a713c41-goog