From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB943C4167B for ; Thu, 22 Dec 2022 13:59:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234764AbiLVN7C (ORCPT ); Thu, 22 Dec 2022 08:59:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229985AbiLVN7A (ORCPT ); Thu, 22 Dec 2022 08:59:00 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C48EC1C413; Thu, 22 Dec 2022 05:58:59 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D683E7679C; Thu, 22 Dec 2022 13:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1671717537; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fKATc+B04yPGuwVoMjN+880psfHG481KAwJvLG9IAuY=; b=WBq6ASIWKvgNfUiotGOXishHrXz1OaT2uQNWZx8kpWVUeCyV4sC+9XgZFcx3hg0MIFTKEE FNnScyG76pkyCA01ofhDM+9a43A/HvwDIbpjwQDoV5rxUo9JtKhJwoEky3vMyPimd2ZCzg a1pscpFiO+riwT3DwA6cEVpiLPIz1/g= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A84B8138FD; Thu, 22 Dec 2022 13:58:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XPInKKFipGMtPgAAMHmgww (envelope-from ); Thu, 22 Dec 2022 13:58:57 +0000 Date: Thu, 22 Dec 2022 14:58:55 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Yann Droneaud Cc: Tejun Heo , Josef Bacik , Jens Axboe , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] blk-iocost: don't make all constants unsigned long long Message-ID: <20221222135855.GC20830@blackbody.suse.cz> References: <20221220201819.1497577-1-ydroneaud@opteya.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kVXhAStRUZ/+rrGn" Content-Disposition: inline In-Reply-To: <20221220201819.1497577-1-ydroneaud@opteya.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kVXhAStRUZ/+rrGn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 20, 2022 at 09:18:19PM +0100, Yann Droneaud wrote: > +enum { > /* switch iff the conditions are met for longer than this */ > AUTOP_CYCLE_NSEC = 10LLU * NSEC_PER_SEC, > +}; This looks gratuitous. What about indivudial #defines with typed literals instead of the "lazy splitting"? Regards, Michal --kVXhAStRUZ/+rrGn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCY6RingAKCRAkDQmsBEOq uVPgAP4y2ImrULaeHe+Vpcp/aQaKYMrV7D3Q1d9z39OiU0CmwQD+PBJ70cOphLPH 5zWBwTr/hS3qRiIJ7Feh9YL4sjTrig8= =ZT8m -----END PGP SIGNATURE----- --kVXhAStRUZ/+rrGn--