mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <markgross@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] platform/x86: simatic-ipc: correct name of a model
Date: Thu, 22 Dec 2022 15:04:43 +0100	[thread overview]
Message-ID: <20221222150443.722e5bf8@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <Y6RRInVaXtOGr8hA@smile.fi.intel.com>

Am Thu, 22 Dec 2022 14:44:18 +0200
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Thu, Dec 22, 2022 at 11:37:19AM +0100, Henning Schild wrote:
> > What we called IPC427G should be renamed to BX-39A to be more in
> > line with the actual product name.  
> 
> Can you tell what does the current name mean?

427G is an internal prototype name using the naming scheme that these
kind of machines used to use for several generations. For some reason
the naming scheme was changed and the public product name is BX-39A.

Please do not ask me why. But if you would happen to own such a device
you would know it as BX-39A _only_.

> Depending on that I would consider either your approach here or
> perhaps just adding a comment in each of the places.

Mentioning the name 427G, even as a comment, does not make much sense.
Since the box is for sale it is called BX-39A and was never called 427G.

I used the internal prototype name and only recently learned that never
became the final name. And this cleanup makes sure nobody gets
confused.

Henning

  reply	other threads:[~2022-12-22 14:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 10:37 [PATCH 0/2] simatic-ipc: enable one more board Henning Schild
2022-12-22 10:37 ` [PATCH 1/2] platform/x86: simatic-ipc: correct name of a model Henning Schild
2022-12-22 12:44   ` Andy Shevchenko
2022-12-22 14:04     ` Henning Schild [this message]
2022-12-27 20:18       ` Andy Shevchenko
2022-12-22 10:37 ` [PATCH 2/2] platform/x86: simatic-ipc: add another model Henning Schild
2023-01-12 18:43 ` [PATCH 0/2] simatic-ipc: enable one more board Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221222150443.722e5bf8@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®