tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9d2f6060fe4c3b49d0cdc1dce1c99296f33379c8 commit: dc55b106ad477c67f969f3432d9070c6846fb557 drm/amd/display: Disable phantom OTG after enable for plane disable date: 6 weeks ago config: s390-randconfig-r044-20221218 compiler: s390-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dc55b106ad477c67f969f3432d9070c6846fb557 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout dc55b106ad477c67f969f3432d9070c6846fb557 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): s390-linux-ld: arch/s390/purgatory/purgatory: in function `sha256_update': >> (.text+0x248c): undefined reference to `ftrace_likely_update' s390-linux-ld: (.text+0x24a4): undefined reference to `ftrace_likely_update' s390-linux-ld: (.text+0x24bc): undefined reference to `ftrace_likely_update' s390-linux-ld: (.text+0x29b4): undefined reference to `ftrace_likely_update' s390-linux-ld: (.text+0x29cc): undefined reference to `ftrace_likely_update' s390-linux-ld: arch/s390/purgatory/purgatory:(.text+0x29e4): more undefined references to `ftrace_likely_update' follow -- drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c: In function 'disable_dangling_plane': >> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:1134:46: error: 'const struct timing_generator_funcs' has no member named 'disable_phantom_crtc' 1134 | if (tg->funcs->disable_phantom_crtc) | ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:1135:50: error: 'const struct timing_generator_funcs' has no member named 'disable_phantom_crtc' 1135 | tg->funcs->disable_phantom_crtc(tg); | ^~ In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32, from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:30: drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h: At top level: drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:137:22: warning: 'SYNAPTICS_DEVICE_ID' defined but not used [-Wunused-const-variable=] 137 | static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA"; | ^~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:134:17: warning: 'DP_SINK_BRANCH_DEV_NAME_7580' defined but not used [-Wunused-const-variable=] 134 | static const u8 DP_SINK_BRANCH_DEV_NAME_7580[] = "7580\x80u"; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:132:22: warning: 'DP_SINK_DEVICE_STR_ID_2' defined but not used [-Wunused-const-variable=] 132 | static const uint8_t DP_SINK_DEVICE_STR_ID_2[] = {7, 1, 8, 7, 5}; | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:131:22: warning: 'DP_SINK_DEVICE_STR_ID_1' defined but not used [-Wunused-const-variable=] 131 | static const uint8_t DP_SINK_DEVICE_STR_ID_1[] = {7, 1, 8, 7, 3}; | ^~~~~~~~~~~~~~~~~~~~~~~ vim +1134 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c 1051 1052 static void disable_dangling_plane(struct dc *dc, struct dc_state *context) 1053 { 1054 int i, j; 1055 struct dc_state *dangling_context = dc_create_state(dc); 1056 struct dc_state *current_ctx; 1057 struct pipe_ctx *pipe; 1058 struct timing_generator *tg; 1059 1060 if (dangling_context == NULL) 1061 return; 1062 1063 dc_resource_state_copy_construct(dc->current_state, dangling_context); 1064 1065 for (i = 0; i < dc->res_pool->pipe_count; i++) { 1066 struct dc_stream_state *old_stream = 1067 dc->current_state->res_ctx.pipe_ctx[i].stream; 1068 bool should_disable = true; 1069 bool pipe_split_change = false; 1070 1071 if ((context->res_ctx.pipe_ctx[i].top_pipe) && 1072 (dc->current_state->res_ctx.pipe_ctx[i].top_pipe)) 1073 pipe_split_change = context->res_ctx.pipe_ctx[i].top_pipe->pipe_idx != 1074 dc->current_state->res_ctx.pipe_ctx[i].top_pipe->pipe_idx; 1075 else 1076 pipe_split_change = context->res_ctx.pipe_ctx[i].top_pipe != 1077 dc->current_state->res_ctx.pipe_ctx[i].top_pipe; 1078 1079 for (j = 0; j < context->stream_count; j++) { 1080 if (old_stream == context->streams[j]) { 1081 should_disable = false; 1082 break; 1083 } 1084 } 1085 if (!should_disable && pipe_split_change && 1086 dc->current_state->stream_count != context->stream_count) 1087 should_disable = true; 1088 1089 if (old_stream && !dc->current_state->res_ctx.pipe_ctx[i].top_pipe && 1090 !dc->current_state->res_ctx.pipe_ctx[i].prev_odm_pipe) { 1091 struct pipe_ctx *old_pipe, *new_pipe; 1092 1093 old_pipe = &dc->current_state->res_ctx.pipe_ctx[i]; 1094 new_pipe = &context->res_ctx.pipe_ctx[i]; 1095 1096 if (old_pipe->plane_state && !new_pipe->plane_state) 1097 should_disable = true; 1098 } 1099 1100 if (should_disable && old_stream) { 1101 pipe = &dc->current_state->res_ctx.pipe_ctx[i]; 1102 tg = pipe->stream_res.tg; 1103 /* When disabling plane for a phantom pipe, we must turn on the 1104 * phantom OTG so the disable programming gets the double buffer 1105 * update. Otherwise the pipe will be left in a partially disabled 1106 * state that can result in underflow or hang when enabling it 1107 * again for different use. 1108 */ 1109 if (old_stream->mall_stream_config.type == SUBVP_PHANTOM) { 1110 if (tg->funcs->enable_crtc) 1111 tg->funcs->enable_crtc(tg); 1112 } 1113 dc_rem_all_planes_for_stream(dc, old_stream, dangling_context); 1114 disable_all_writeback_pipes_for_stream(dc, old_stream, dangling_context); 1115 1116 if (dc->hwss.apply_ctx_for_surface) { 1117 apply_ctx_interdependent_lock(dc, dc->current_state, old_stream, true); 1118 dc->hwss.apply_ctx_for_surface(dc, old_stream, 0, dangling_context); 1119 apply_ctx_interdependent_lock(dc, dc->current_state, old_stream, false); 1120 dc->hwss.post_unlock_program_front_end(dc, dangling_context); 1121 } 1122 if (dc->hwss.program_front_end_for_ctx) { 1123 dc->hwss.interdependent_update_lock(dc, dc->current_state, true); 1124 dc->hwss.program_front_end_for_ctx(dc, dangling_context); 1125 dc->hwss.interdependent_update_lock(dc, dc->current_state, false); 1126 dc->hwss.post_unlock_program_front_end(dc, dangling_context); 1127 } 1128 /* We need to put the phantom OTG back into it's default (disabled) state or we 1129 * can get corruption when transition from one SubVP config to a different one. 1130 * The OTG is set to disable on falling edge of VUPDATE so the plane disable 1131 * will still get it's double buffer update. 1132 */ 1133 if (old_stream->mall_stream_config.type == SUBVP_PHANTOM) { > 1134 if (tg->funcs->disable_phantom_crtc) 1135 tg->funcs->disable_phantom_crtc(tg); 1136 } 1137 } 1138 } 1139 1140 current_ctx = dc->current_state; 1141 dc->current_state = dangling_context; 1142 dc_release_state(current_ctx); 1143 } 1144 -- 0-DAY CI Kernel Test Service https://01.org/lkp