From: Tanmay Shah <tanmay.shah@amd.com>
To: <christophe.jaillet@wanadoo.fr>
Cc: <jassisinghbrar@gmail.com>, <kernel-janitors@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <michal.simek@amd.com>,
<tanmay.shah@amd.com>
Subject: RE: [PATCH] mailbox: zynq: Switch to flexible array to simplify code
Date: Thu, 22 Dec 2022 18:44:07 -0800 [thread overview]
Message-ID: <20221223024407.2107699-1-tanmay.shah@amd.com> (raw)
In-Reply-To: <3c21e60417a0b57e7a80976b786726048119b5cf.1668932733.git.christophe.jaillet@wanadoo.fr>
Reviewed-by: Tanmay Shah <tanmay.shah@amd.com>
Thanks for your patch. The patch looks good to me.
(Update: Fixed subject of email)
From 48e51754dd7cd49abdf3adc7a01e6863bf5e3764 Mon Sep 17 00:00:00 2001
>From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>Date: Sun, 20 Nov 2022 09:25:54 +0100
>Subject: [PATCH] mailbox: zynq: Switch to flexible array to simplify code
>
>Using flexible array is more straight forward. It
> - saves 1 pointer in the 'zynqmp_ipi_pdata' structure
> - saves an indirection when using this array
> - saves some LoC and avoids some always spurious pointer arithmetic
>
>Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>---
> drivers/mailbox/zynqmp-ipi-mailbox.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
>index 12e004ff1a14..a4c8d23c76e2 100644
>--- a/drivers/mailbox/zynqmp-ipi-mailbox.c
>+++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
>@@ -110,7 +110,7 @@ struct zynqmp_ipi_pdata {
> unsigned int method;
> u32 local_id;
> int num_mboxes;
>- struct zynqmp_ipi_mbox *ipi_mboxes;
>+ struct zynqmp_ipi_mbox ipi_mboxes[];
> };
>
> static struct device_driver zynqmp_ipi_mbox_driver = {
>@@ -635,7 +635,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
> int num_mboxes, ret = -EINVAL;
>
> num_mboxes = of_get_child_count(np);
>- pdata = devm_kzalloc(dev, sizeof(*pdata) + (num_mboxes * sizeof(*mbox)),
>+ pdata = devm_kzalloc(dev, struct_size(pdata, ipi_mboxes, num_mboxes),
> GFP_KERNEL);
> if (!pdata)
> return -ENOMEM;
>@@ -649,8 +649,6 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
> }
>
> pdata->num_mboxes = num_mboxes;
>- pdata->ipi_mboxes = (struct zynqmp_ipi_mbox *)
>- ((char *)pdata + sizeof(*pdata));
>
> mbox = pdata->ipi_mboxes;
> for_each_available_child_of_node(np, nc) {
>
>--
>2.25.1
prev parent reply other threads:[~2022-12-23 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 8:25 Christophe JAILLET
2022-12-23 2:34 ` Tanmay Shah
2022-12-23 2:44 ` Tanmay Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221223024407.2107699-1-tanmay.shah@amd.com \
--to=tanmay.shah@amd.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®