mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Maíra Canal" <mcanal@igalia.com>
To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: "Melissa Wen" <mwen@igalia.com>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Russell King" <linux+etnaviv@armlinux.org.uk>,
	"Christian Gmeiner" <christian.gmeiner@gmail.com>,
	etnaviv@lists.freedesktop.org, noralf@tronnes.org,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Brian Starkey" <brian.starkey@arm.com>,
	"Emma Anholt" <emma@anholt.net>,
	"Alexey Brodkin" <abrodkin@synopsys.com>,
	"David Airlie" <airlied@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Gurchetan Singh" <gurchetansingh@chromium.org>,
	"Chia-I Wu" <olvaffe@gmail.com>,
	"Tomi Valkeinen" <tomba@kernel.org>,
	"Maíra Canal" <mcanal@igalia.com>
Subject: [PATCH 1/9] drm/etnaviv: use new debugfs device-centered functions
Date: Mon, 26 Dec 2022 12:50:21 -0300	[thread overview]
Message-ID: <20221226155029.244355-2-mcanal@igalia.com> (raw)
In-Reply-To: <20221226155029.244355-1-mcanal@igalia.com>

Replace the use of drm_debugfs_create_files() with the new
drm_debugfs_add_files() function, which center the debugfs files
management on the drm_device instead of drm_minor. Moreover, remove the
debugfs_init hook and add the debugfs files directly on etnaviv_bind(),
before drm_dev_register().

Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 drivers/gpu/drm/etnaviv/etnaviv_drv.c | 29 +++++++++++----------------
 1 file changed, 12 insertions(+), 17 deletions(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 1d2b4fb4bcf8..2b265460672e 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -191,22 +191,22 @@ static int etnaviv_ring_show(struct etnaviv_gpu *gpu, struct seq_file *m)
 
 static int show_unlocked(struct seq_file *m, void *arg)
 {
-	struct drm_info_node *node = (struct drm_info_node *) m->private;
-	struct drm_device *dev = node->minor->dev;
+	struct drm_debugfs_entry *entry = m->private;
+	struct drm_device *dev = entry->dev;
 	int (*show)(struct drm_device *dev, struct seq_file *m) =
-			node->info_ent->data;
+			entry->file.data;
 
 	return show(dev, m);
 }
 
 static int show_each_gpu(struct seq_file *m, void *arg)
 {
-	struct drm_info_node *node = (struct drm_info_node *) m->private;
-	struct drm_device *dev = node->minor->dev;
+	struct drm_debugfs_entry *entry = m->private;
+	struct drm_device *dev = entry->dev;
 	struct etnaviv_drm_private *priv = dev->dev_private;
 	struct etnaviv_gpu *gpu;
 	int (*show)(struct etnaviv_gpu *gpu, struct seq_file *m) =
-			node->info_ent->data;
+			entry->file.data;
 	unsigned int i;
 	int ret = 0;
 
@@ -223,20 +223,13 @@ static int show_each_gpu(struct seq_file *m, void *arg)
 	return ret;
 }
 
-static struct drm_info_list etnaviv_debugfs_list[] = {
+static struct drm_debugfs_info etnaviv_debugfs_list[] = {
 		{"gpu", show_each_gpu, 0, etnaviv_gpu_debugfs},
 		{"gem", show_unlocked, 0, etnaviv_gem_show},
 		{ "mm", show_unlocked, 0, etnaviv_mm_show },
 		{"mmu", show_each_gpu, 0, etnaviv_mmu_show},
 		{"ring", show_each_gpu, 0, etnaviv_ring_show},
 };
-
-static void etnaviv_debugfs_init(struct drm_minor *minor)
-{
-	drm_debugfs_create_files(etnaviv_debugfs_list,
-				 ARRAY_SIZE(etnaviv_debugfs_list),
-				 minor->debugfs_root, minor);
-}
 #endif
 
 /*
@@ -478,9 +471,6 @@ static const struct drm_driver etnaviv_drm_driver = {
 	.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
 	.gem_prime_import_sg_table = etnaviv_gem_prime_import_sg_table,
 	.gem_prime_mmap     = drm_gem_prime_mmap,
-#ifdef CONFIG_DEBUG_FS
-	.debugfs_init       = etnaviv_debugfs_init,
-#endif
 	.ioctls             = etnaviv_ioctls,
 	.num_ioctls         = DRM_ETNAVIV_NUM_IOCTLS,
 	.fops               = &fops,
@@ -534,6 +524,11 @@ static int etnaviv_bind(struct device *dev)
 
 	load_gpu(drm);
 
+#ifdef CONFIG_DEBUG_FS
+	drm_debugfs_add_files(drm, etnaviv_debugfs_list,
+			      ARRAY_SIZE(etnaviv_debugfs_list));
+#endif
+
 	ret = drm_dev_register(drm, 0);
 	if (ret)
 		goto out_unbind;
-- 
2.38.1


  reply	other threads:[~2022-12-26 15:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-26 15:50 [PATCH 0/9] Convert drivers to the " Maíra Canal
2022-12-26 15:50 ` Maíra Canal [this message]
2022-12-26 15:50 ` [PATCH 2/9] drm/gud: use " Maíra Canal
2023-01-04 13:32   ` Noralf Trønnes
2023-01-06 19:48   ` Maíra Canal
2022-12-26 15:50 ` [PATCH 3/9] drm/arm/hdlcd: " Maíra Canal
2023-01-03 13:48   ` Liviu Dudau
2023-01-06 19:49   ` Maíra Canal
2022-12-26 15:50 ` [PATCH 4/9] drm/pl111: " Maíra Canal
2023-01-05 13:54   ` kernel test robot
2022-12-26 15:50 ` [PATCH 5/9] drm/arc: " Maíra Canal
2023-01-06 19:54   ` Daniel Vetter
2022-12-26 15:50 ` [PATCH 6/9] drm/virtio: " Maíra Canal
2022-12-26 15:50 ` [PATCH 7/9] drm/omap: " Maíra Canal
2022-12-26 15:50 ` [PATCH 8/9] drm/qxl: remove unused debugfs structure Maíra Canal
2022-12-26 15:50 ` [PATCH 9/9] drm/qxl: use new debugfs device-centered functions Maíra Canal
2023-01-06 20:00   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221226155029.244355-2-mcanal@igalia.com \
    --to=mcanal@igalia.com \
    --cc=abrodkin@synopsys.com \
    --cc=airlied@gmail.com \
    --cc=airlied@redhat.com \
    --cc=andrealmeid@igalia.com \
    --cc=brian.starkey@arm.com \
    --cc=christian.gmeiner@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=etnaviv@lists.freedesktop.org \
    --cc=gurchetansingh@chromium.org \
    --cc=kraxel@redhat.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux+etnaviv@armlinux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=mwen@igalia.com \
    --cc=noralf@tronnes.org \
    --cc=olvaffe@gmail.com \
    --cc=tomba@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®