From: Ming Lei <ming.lei@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
John Garry <john.garry@huawei.com>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V4 0/6] genirq/affinity: Abstract APIs from managed irq affinity spread
Date: Tue, 27 Dec 2022 10:28:59 +0800 [thread overview]
Message-ID: <20221227022905.352674-1-ming.lei@redhat.com> (raw)
Hello,
irq_build_affinity_masks() actually grouping CPUs evenly into each managed
irq vector according to NUMA and CPU locality, and it is reasonable to abstract
one generic API for grouping CPUs evenly, the idea is suggested by Thomas
Gleixner.
group_cpus_evenly() is abstracted and put into lib/, so blk-mq can re-use
it to build default queue mapping.
blk-mq IO perf data is observed as more stable, meantime with big
improvement, see detailed data in the last patch.
Please consider it for v6.3!
V4:
- address comments from John, not export the API, given so far no
module uses this symbol
- add maintainer entry for new added lib/group_cpus.c
- rebase on 6.2
V3:
- fix build failure in case of !CONFIG_SMP, only 6/7 is changed
V2:
- fix build failure in case of !CONFIG_SMP
- fix commit log typo
- fix memory leak in last patch
- add reviewed-by
Since RFC:
- remove RFC
- rebase on -next tree
Ming Lei (6):
genirq/affinity: Remove the 'firstvec' parameter from
irq_build_affinity_masks
genirq/affinity: Pass affinity managed mask array to
irq_build_affinity_masks
genirq/affinity: Don't pass irq_affinity_desc array to
irq_build_affinity_masks
genirq/affinity: Rename irq_build_affinity_masks as group_cpus_evenly
genirq/affinity: Move group_cpus_evenly() into lib/
blk-mq: Build default queue map via group_cpus_evenly()
MAINTAINERS | 2 +
block/blk-mq-cpumap.c | 63 ++----
include/linux/group_cpus.h | 14 ++
kernel/irq/affinity.c | 405 +----------------------------------
lib/Makefile | 2 +
lib/group_cpus.c | 427 +++++++++++++++++++++++++++++++++++++
6 files changed, 467 insertions(+), 446 deletions(-)
create mode 100644 include/linux/group_cpus.h
create mode 100644 lib/group_cpus.c
--
2.31.1
next reply other threads:[~2022-12-27 2:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 2:28 Ming Lei [this message]
2022-12-27 2:29 ` [PATCH V4 1/6] genirq/affinity: Remove the 'firstvec' parameter from irq_build_affinity_masks Ming Lei
2023-01-11 9:23 ` John Garry
2023-01-17 17:54 ` [tip: irq/core] " tip-bot2 for Ming Lei
2022-12-27 2:29 ` [PATCH V4 2/6] genirq/affinity: Pass affinity managed mask array to irq_build_affinity_masks Ming Lei
2023-01-11 9:46 ` John Garry
2023-01-17 17:54 ` [tip: irq/core] " tip-bot2 for Ming Lei
2022-12-27 2:29 ` [PATCH V4 3/6] genirq/affinity: Don't pass irq_affinity_desc " Ming Lei
2023-01-11 10:16 ` John Garry
2023-01-17 17:54 ` [tip: irq/core] " tip-bot2 for Ming Lei
2022-12-27 2:29 ` [PATCH V4 4/6] genirq/affinity: Rename irq_build_affinity_masks as group_cpus_evenly Ming Lei
2023-01-17 17:54 ` [tip: irq/core] " tip-bot2 for Ming Lei
2022-12-27 2:29 ` [PATCH V4 5/6] genirq/affinity: Move group_cpus_evenly() into lib/ Ming Lei
2023-01-17 17:54 ` [tip: irq/core] " tip-bot2 for Ming Lei
2023-01-18 11:37 ` [tip: irq/core] genirq/affinity: Only build SMP-only helper functions on SMP kernels tip-bot2 for Ingo Molnar
2022-12-27 2:29 ` [PATCH V4 6/6] blk-mq: Build default queue map via group_cpus_evenly() Ming Lei
2023-01-11 9:58 ` John Garry
2023-01-17 17:54 ` [tip: irq/core] " tip-bot2 for Ming Lei
2023-01-11 2:18 ` [PATCH V4 0/6] genirq/affinity: Abstract APIs from managed irq affinity spread Ming Lei
2023-01-11 18:58 ` Thomas Gleixner
2023-01-12 1:45 ` Ming Lei
2023-01-11 19:04 ` Jens Axboe
2023-01-16 19:13 ` Thomas Gleixner
2023-01-17 13:12 ` Jens Axboe
2023-01-11 10:06 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221227022905.352674-1-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®