From: Bjorn Andersson <andersson@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address
Date: Tue, 27 Dec 2022 22:03:17 -0600 [thread overview]
Message-ID: <20221228040317.wmfjq2il5q4uzdtx@builder.lan> (raw)
In-Reply-To: <f260fd4e-a25b-6ae5-0952-63f68b5330fc@linaro.org>
On Sun, Dec 11, 2022 at 09:15:36PM +0100, Krzysztof Kozlowski wrote:
> On 10/12/2022 13:26, Konrad Dybcio wrote:
> >
> >
> > On 10.12.2022 12:33, Krzysztof Kozlowski wrote:
> >> By coding style, unit address should not start with 0x.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> > We somehow keep running into solving the same style issues :P
> >
> > https://lore.kernel.org/lkml/20220930191049.123256-8-konrad.dybcio@somainline.org/
> >
>
> Eh, this should have been just applied long time ago...
>
That's patch 7 in a series, which I would be expecting to see respun
per your request for changes.
@Konrad, please put fixes like that first in your series - or just send
them separate from the series.
Regards,
Bjorn
next prev parent reply other threads:[~2022-12-28 4:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 11:33 Krzysztof Kozlowski
2022-12-10 12:26 ` Konrad Dybcio
2022-12-11 20:15 ` Krzysztof Kozlowski
2022-12-28 4:03 ` Bjorn Andersson [this message]
2022-12-28 4:36 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221228040317.wmfjq2il5q4uzdtx@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®