From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev, Kees Cook <keescook@chromium.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: lib/memcpy_kunit.c:299 init_large() warn: calling memset(x, y, ARRAY_SIZE());
Date: Tue, 3 Jan 2023 10:58:28 +0300 [thread overview]
Message-ID: <202212311919.oZKZmewP-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c8451c141e07a8d05693f6c8d0e418fbb4b68bb7
commit: 96fce387d58fa8eae6e8d9b1ecdfbc18292d7a68 kunit/memcpy: Add dynamic size and window tests
config: ia64-randconfig-m031-20221229
compiler: ia64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
lib/memcpy_kunit.c:299 init_large() warn: calling memset(x, y, ARRAY_SIZE());
vim +299 lib/memcpy_kunit.c
96fce387d58fa8 Kees Cook 2022-09-28 290
96fce387d58fa8 Kees Cook 2022-09-28 291 /* Get many bit patterns. */
96fce387d58fa8 Kees Cook 2022-09-28 292 get_random_bytes(large_src, ARRAY_SIZE(large_src));
^^^^^^^^^^^^^^^^^^^^^
96fce387d58fa8 Kees Cook 2022-09-28 293
96fce387d58fa8 Kees Cook 2022-09-28 294 /* Make sure we have non-zero edges. */
96fce387d58fa8 Kees Cook 2022-09-28 295 set_random_nonzero(test, &large_src[0]);
96fce387d58fa8 Kees Cook 2022-09-28 296 set_random_nonzero(test, &large_src[ARRAY_SIZE(large_src) - 1]);
96fce387d58fa8 Kees Cook 2022-09-28 297
96fce387d58fa8 Kees Cook 2022-09-28 298 /* Explicitly zero the entire destination. */
96fce387d58fa8 Kees Cook 2022-09-28 @299 memset(large_dst, 0, ARRAY_SIZE(large_dst));
ARRAY_SIZE() is the number of elements. You want sizeof(). My guess is
that probably large_dst has the 1 byte elements, but you know...
96fce387d58fa8 Kees Cook 2022-09-28 300 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2023-01-03 7:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202212311919.oZKZmewP-lkp@intel.com \
--to=error27@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®