mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marijn Suijten <marijn.suijten@somainline.org>
To: Adam Skladowski <a39.skl@gmail.com>
Cc: phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Bjorn Andersson <andersson@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	AngeloGioacchino Del Regno <kholk11@gmail.com>,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: pinctrl-msm8976: Correct function names for wcss pins
Date: Sat, 31 Dec 2022 21:14:27 +0100	[thread overview]
Message-ID: <20221231201427.4zvubd4cqkaphayd@SoMainline.org> (raw)
In-Reply-To: <20221231164250.74550-1-a39.skl@gmail.com>

On 2022-12-31 17:42:50, Adam Skladowski wrote:
> Adjust names of function for wcss pins, also fix third gpio in bt group.

Agreed, the wcss_wlan[210]_groups arrays and functions are unused prior
to this patch nor are pins 40/41/42 part of wcss_wlan_groups (which only
contains 43 and 44).  Same for the BT fix, the pingroup for pin 48 is
clearly wcss_bt and there's none for pin 88.

You could have made that more clear in the commit message though (and
I'm not even sure if pinctrl allows the pins to be used when the groups
are misaligned like this, at least there's a fixes: tag), but for the
change itself:

Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>

> Fixes: bcd11493f0ab ("pinctrl: qcom: Add a pinctrl driver for MSM8976 and 8956")
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> ---
>  drivers/pinctrl/qcom/pinctrl-msm8976.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm8976.c b/drivers/pinctrl/qcom/pinctrl-msm8976.c
> index ec43edf9b660..e11d84584719 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm8976.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm8976.c
> @@ -733,7 +733,7 @@ static const char * const codec_int2_groups[] = {
>  	"gpio74",
>  };
>  static const char * const wcss_bt_groups[] = {
> -	"gpio39", "gpio47", "gpio88",
> +	"gpio39", "gpio47", "gpio48",
>  };
>  static const char * const sdc3_groups[] = {
>  	"gpio39", "gpio40", "gpio41",
> @@ -958,9 +958,9 @@ static const struct msm_pingroup msm8976_groups[] = {
>  	PINGROUP(37, NA, NA, NA, qdss_tracedata_b, NA, NA, NA, NA, NA),
>  	PINGROUP(38, NA, NA, NA, NA, NA, NA, NA, qdss_tracedata_b, NA),
>  	PINGROUP(39, wcss_bt, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> -	PINGROUP(40, wcss_wlan, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> -	PINGROUP(41, wcss_wlan, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> -	PINGROUP(42, wcss_wlan, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> +	PINGROUP(40, wcss_wlan2, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> +	PINGROUP(41, wcss_wlan1, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> +	PINGROUP(42, wcss_wlan0, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
>  	PINGROUP(43, wcss_wlan, sdc3, NA, NA, qdss_tracedata_a, NA, NA, NA, NA),
>  	PINGROUP(44, wcss_wlan, sdc3, NA, NA, NA, NA, NA, NA, NA),
>  	PINGROUP(45, wcss_fm, NA, qdss_tracectl_a, NA, NA, NA, NA, NA, NA),
> -- 
> 2.25.1
> 

  reply	other threads:[~2022-12-31 20:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-31 16:42 Adam Skladowski
2022-12-31 20:14 ` Marijn Suijten [this message]
2023-01-09 13:40 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221231201427.4zvubd4cqkaphayd@SoMainline.org \
    --to=marijn.suijten@somainline.org \
    --cc=a39.skl@gmail.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=kholk11@gmail.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®