From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6EDDC3DA7A for ; Mon, 2 Jan 2023 11:17:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232604AbjABLRx (ORCPT ); Mon, 2 Jan 2023 06:17:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232471AbjABLRi (ORCPT ); Mon, 2 Jan 2023 06:17:38 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C95862EA for ; Mon, 2 Jan 2023 03:17:36 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3DED524000E; Mon, 2 Jan 2023 11:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1672658254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qw89x4Kg3SjlkQR0d7Jy+ZdKD84uyDA8n9IHbMQerAk=; b=E7GU6OdwpnSph+DsCbh/iHthBFRhCzgPqySVXfLkFfxUw+A1jVk4IN9udkeTALUQc0p1Jj hEjgv1FUITOC3FIITRbJOA7gyi26pCtsE4pSMhejJ38Vluo5fID5FY+de3C664J/4kQ/8G rwgGZ2UjywqS2ItB5LrzuyivFsOms4xohHLUCLi8J8kQ33ql0xBCqk/BIYCktciMuJUtww 03eZxIYOhKp/2Z7elIgXisd0QxfsnKu8wF40kxJrmIvC0teqCaPy9Pr48MQOrHEJfZ4ljf iV9qz/OExayXkFpPWOTq2JwbAxPr9MUYkU/bqZvIgJdwFTUG/xugJ57wqxnnLQ== From: Miquel Raynal To: Arnd Bergmann , Tudor Ambarus , Pratyush Yadav Cc: Miquel Raynal , Arnd Bergmann , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Takahiro Kuwano , Sai Krishna Potthuri , Boris Brezillon , Mauro Lima , Mika Westerberg , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] mtd: cfi: allow building spi-intel standalone Date: Mon, 2 Jan 2023 12:17:29 +0100 Message-Id: <20230102111729.85746-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221220141352.1486360-1-arnd@kernel.org> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'd19ab1f785d0b6b9f709799f0938658903821ba1' Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-12-20 at 14:13:34 UTC, Arnd Bergmann wrote: > From: Arnd Bergmann > > When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver > fails to build, as it includes the shared CFI header: > > include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. [-Werror=cpp] > 62 | #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. > > linux/mtd/spi-nor.h does not actually need to include cfi.h, so > remove the inclusion here to fix the warning. This uncovers a > missing #include in spi-nor/core.c so add that there to > prevent a different build issue. > > Fixes: e23e5a05d1fd ("mtd: spi-nor: intel-spi: Convert to SPI MEM") > Signed-off-by: Arnd Bergmann > Reviewed-by: Mika Westerberg > Reviewed-by: Tokunori Ikegami > Acked-by: Pratyush Yadav > Reviewed-by: Tudor Ambarus Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks. Miquel