From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B90CC4708E for ; Mon, 2 Jan 2023 14:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231445AbjABOgX (ORCPT ); Mon, 2 Jan 2023 09:36:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233028AbjABOft (ORCPT ); Mon, 2 Jan 2023 09:35:49 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0C6765B9 for ; Mon, 2 Jan 2023 06:35:45 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so23947258wma.1 for ; Mon, 02 Jan 2023 06:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ixsystems.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TJq3TeEMVEa4cxKJPhRTEvU3LME7/v1uYktVvktqpGE=; b=giKYD8zRfEz+aTz2PgAOBuReNmF+3ipE0aYhpWrnbzcVWA26vzIqDcD5FLnSINxL+M LFgGo5qElo0bKpiGfxDHPVQWCGxhFZKx+3Y/aZn1AWx0/kyJ9opa93mRMDHf0nnNlhvl PA3JyflJbfKHZwlrMzULsTWiA8AahjGq9TK5CQj+MwD0qIDt/S2DYL0NF/9yBKPJR6Hd LUZq3p6uP6VrHbVutXsxh5dGaQFGXmtNXvhh4pvj+FWdD3tpqULpz+WOHzCQbXHsJhUk FzhGm4wbNSJ9Yc+0fC/CyXB2H4rYo1IVLlPto8ymlfhlFf4cIa9LN/tUuQBlArcXvoLX RLdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TJq3TeEMVEa4cxKJPhRTEvU3LME7/v1uYktVvktqpGE=; b=Ka2he3pkMryMhU97CGl+BJQV07IoJC6chJa8veNiCIOLg1DJ3ZRK/QaLD/4LS5KyWx 680EU/rHEuGJ9Bu7gW5ljEtu+atMRBQu0r9MZHrWN2t2ucVV1HdKMh3CWWSqFohXD0NE rocP51gD4FG5ZiWcy6xyyed6WOs+6Yv9vdECCSKWVWapVDQzH7iBN/Gcj6S1ApZm5pmL BeTYfR0K3ln1nnpWbGELx+N82+PR+FTt9sIAt1vJX8/AuSWok3xdR0XgE7m1bVvsTpTw rlwULL2WEaBueSO218cmvkmA/CMkQJnxnrLqqkY+4lN/+AKSyRZaUx4TCRh98QRTwx+I XNBQ== X-Gm-Message-State: AFqh2krF1VZddV5/L8rWUvIk8XpVUdOypSaryw1aC7OBtiHxHotLxWwy MtJygNmHmvy1rIO9eOyT1B955w== X-Google-Smtp-Source: AMrXdXtn/wbjdX4CuagPWVi+PJUie6Oio+Ubkoxzq0YYqAsyUDeIQFycUSYBPWddMHy9yd8ByXRO6Q== X-Received: by 2002:a05:600c:22d9:b0:3d3:56e6:4f0d with SMTP id 25-20020a05600c22d900b003d356e64f0dmr29637713wmg.7.1672670144202; Mon, 02 Jan 2023 06:35:44 -0800 (PST) Received: from hamza-HP-ZBook-15-G3 ([2400:adc1:158:c700:a835:5821:1f98:828f]) by smtp.gmail.com with ESMTPSA id e16-20020adfdbd0000000b002362f6fcaf5sm28662666wrj.48.2023.01.02.06.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 06:35:43 -0800 (PST) Date: Mon, 2 Jan 2023 19:35:38 +0500 From: Ameer Hamza To: David Laight Cc: "viro@zeniv.linux.org.uk" , "jlayton@kernel.org" , "chuck.lever@oracle.com" , "arnd@arndb.de" , "guoren@kernel.org" , "palmer@rivosinc.com" , "f.fainelli@gmail.com" , "slark_xiao@163.com" , "richard.henderson@linaro.org" , "ink@jurassic.park.msu.ru" , "mattst88@gmail.com" , "James.Bottomley@HansenPartnership.com" , "deller@gmx.de" , "davem@davemloft.net" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "awalker@ixsystems.com" , "sparclinux@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-alpha@vger.kernel.org" Subject: Re: [PATCH v2] Add new open(2) flag - O_EMPTY_PATH Message-ID: <20230102143538.GA8886@hamza-HP-ZBook-15-G3> References: <202212310842.ysbymPHY-lkp@intel.com> <20221231235618.117201-1-ahamza@ixsystems.com> <4b39cf528148470c934fb5823b35e9d5@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b39cf528148470c934fb5823b35e9d5@AcuMS.aculab.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 02, 2023 at 02:01:38PM +0000, David Laight wrote: > From: Ameer Hamza > > Sent: 31 December 2022 23:56 > > > > This patch adds a new flag O_EMPTY_PATH that allows openat and open > > system calls to open a file referenced by fd if the path is empty, > > and it is very similar to the FreeBSD O_EMPTY_PATH flag. This can be > > beneficial in some cases since it would avoid having to grant /proc > > access to things like samba containers for reopening files to change > > flags in a race-free way. > > > > But what does it do? > (Apart from add code to a common kernel code path.) > > David It can convert an O_PATH descriptor to one suitable for r/w work. If we already have a file descriptor: {opath_fd = open(<path>, O_PATH);}, we can call {openat(opath_fd, "", O_EMPTY_PATH | O_RDWR)} instead of going through procfs {open(/proc/self/fd/<opath_fd>, O_RDWR)}. > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) >