From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20CEFC4708E for ; Mon, 2 Jan 2023 20:31:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236202AbjABUa6 (ORCPT ); Mon, 2 Jan 2023 15:30:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234878AbjABUaQ (ORCPT ); Mon, 2 Jan 2023 15:30:16 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2898CB850 for ; Mon, 2 Jan 2023 12:30:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672691412; x=1704227412; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CFo7ISntdmpoVi76v1LxoXR/BugA3bqZ0RVMplT5JSw=; b=QWc6GMDAk0UB+xZIvCvaOUFT7wj4IMqs2iwyU/gL8vRnDGjO/eyovmBI hytVSkFB6GF6Szuc4VN0ubAfRrZmHRgE9bMeKn50QXkwA7V2k7Wu8X+zD gnvXsAFyNRLK/iqqGSjuV6tO6G5aC9mu4U2iB6hdFlSb8dY4YQkGBiVVN xbv1iDmGecnju36HstRSiVFptbpkwdLpoXn7rl7G3/RvORmhiJ01pdTAC Xjxhu6mwYtTgaD7wyeucsO0cGmLENzig33ytBe/U/AGizfNSDHqFY5okb g0MbRnHCEyiqFKyQ7utyATqF3FRjNOafoFi+Cb/6zlOTo/C8MHMNlDy7h w==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="301224155" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="301224155" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 12:30:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="796962523" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="796962523" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 02 Jan 2023 12:30:08 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id E3A3219E; Mon, 2 Jan 2023 22:30:40 +0200 (EET) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai Subject: [PATCH v1 5/5] ASoC: Intel: sof-wm8804: Replace open coded acpi_dev_put() Date: Mon, 2 Jan 2023 22:30:37 +0200 Message-Id: <20230102203037.16120-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230102203037.16120-1-andriy.shevchenko@linux.intel.com> References: <20230102203037.16120-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of calling put_device(&adev->dev) where adev is a pointer to an ACPI device, use specific call, i.e. acpi_dev_put(). Also move it out of the conditional to make it more visible in case some other code will be added which may use that pointer. We need to keep a reference as long as we use the pointer. Signed-off-by: Andy Shevchenko --- sound/soc/intel/boards/sof_wm8804.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/sof_wm8804.c b/sound/soc/intel/boards/sof_wm8804.c index 54395e2ededc..fbad5a73de44 100644 --- a/sound/soc/intel/boards/sof_wm8804.c +++ b/sound/soc/intel/boards/sof_wm8804.c @@ -269,9 +269,9 @@ static int sof_wm8804_probe(struct platform_device *pdev) if (adev) { snprintf(codec_name, sizeof(codec_name), "%s%s", "i2c-", acpi_dev_name(adev)); - put_device(&adev->dev); dailink[dai_index].codecs->name = codec_name; } + acpi_dev_put(adev); snd_soc_card_set_drvdata(card, ctx); -- 2.35.1