Hi Aditya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wireless-next/main] [also build test WARNING on wireless/main linus/master v6.2-rc2 next-20221226] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Aditya-Garg/brcmfmac-Add-PCIe-ID-of-BCM4355-chip-found-on-T2-Macs/20230102-234714 base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main patch link: https://lore.kernel.org/r/B5647DBC-3D99-412F-BD04-071950D3CD48%40live.com patch subject: [PATCH 2/2] brcmfmac: Add PCIe ID of BCM4355 chip found on T2 Macs config: x86_64-allyesconfig compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/960ea39e9583e9a433e6fc2ad30e919cc8cdcf0c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Aditya-Garg/brcmfmac-Add-PCIe-ID-of-BCM4355-chip-found-on-T2-Macs/20230102-234714 git checkout 960ea39e9583e9a433e6fc2ad30e919cc8cdcf0c # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/wireless/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:40: drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h:45:9: error: expected '}' before '{' token 45 | { chipid, mask, BRCM_ ## name ## _FIRMWARE_BASENAME } | ^ drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:82:9: note: in expansion of macro 'BRCMF_FW_ENTRY' 82 | BRCMF_FW_ENTRY(BRCM_CC_4356_CHIP_ID, 0xFFFFFFFF, 4356), | ^~~~~~~~~~~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:75:67: note: to match this '{' 75 | static const struct brcmf_firmware_mapping brcmf_pcie_fwnames[] = { | ^ In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:40: >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h:33:19: warning: 'BRCM_4371_FIRMWARE_BASENAME' defined but not used [-Wunused-const-variable=] 33 | static const char BRCM_ ## fw_name ## _FIRMWARE_BASENAME[] = \ | ^~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:63:1: note: in expansion of macro 'BRCMF_FW_DEF' 63 | BRCMF_FW_DEF(4371, "brcmfmac4371-pcie"); | ^~~~~~~~~~~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h:33:19: warning: 'BRCM_4366B_FIRMWARE_BASENAME' defined but not used [-Wunused-const-variable=] 33 | static const char BRCM_ ## fw_name ## _FIRMWARE_BASENAME[] = \ | ^~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:61:1: note: in expansion of macro 'BRCMF_FW_DEF' 61 | BRCMF_FW_DEF(4366B, "brcmfmac4366b-pcie"); | ^~~~~~~~~~~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h:33:19: warning: 'BRCM_4365B_FIRMWARE_BASENAME' defined but not used [-Wunused-const-variable=] 33 | static const char BRCM_ ## fw_name ## _FIRMWARE_BASENAME[] = \ | ^~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:59:1: note: in expansion of macro 'BRCMF_FW_DEF' 59 | BRCMF_FW_DEF(4365B, "brcmfmac4365b-pcie"); | ^~~~~~~~~~~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h:33:19: warning: 'BRCM_4364_FIRMWARE_BASENAME' defined but not used [-Wunused-const-variable=] 33 | static const char BRCM_ ## fw_name ## _FIRMWARE_BASENAME[] = \ | ^~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:58:1: note: in expansion of macro 'BRCMF_FW_DEF' 58 | BRCMF_FW_DEF(4364, "brcmfmac4364-pcie"); | ^~~~~~~~~~~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h:33:19: warning: 'BRCM_4359_FIRMWARE_BASENAME' defined but not used [-Wunused-const-variable=] 33 | static const char BRCM_ ## fw_name ## _FIRMWARE_BASENAME[] = \ | ^~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:57:1: note: in expansion of macro 'BRCMF_FW_DEF' 57 | BRCMF_FW_DEF(4359, "brcmfmac4359-pcie"); | ^~~~~~~~~~~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h:33:19: warning: 'BRCM_4358_FIRMWARE_BASENAME' defined but not used [-Wunused-const-variable=] 33 | static const char BRCM_ ## fw_name ## _FIRMWARE_BASENAME[] = \ | ^~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:56:1: note: in expansion of macro 'BRCMF_FW_DEF' 56 | BRCMF_FW_DEF(4358, "brcmfmac4358-pcie"); | ^~~~~~~~~~~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h:39:19: warning: 'BRCM_43570_FIRMWARE_BASENAME' defined but not used [-Wunused-const-variable=] 39 | static const char BRCM_ ## fw_name ## _FIRMWARE_BASENAME[] = \ | ^~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:55:1: note: in expansion of macro 'BRCMF_FW_CLM_DEF' 55 | BRCMF_FW_CLM_DEF(43570, "brcmfmac43570-pcie"); | ^~~~~~~~~~~~~~~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h:39:19: warning: 'BRCM_4356_FIRMWARE_BASENAME' defined but not used [-Wunused-const-variable=] 39 | static const char BRCM_ ## fw_name ## _FIRMWARE_BASENAME[] = \ | ^~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:54:1: note: in expansion of macro 'BRCMF_FW_CLM_DEF' 54 | BRCMF_FW_CLM_DEF(4356, "brcmfmac4356-pcie"); | ^~~~~~~~~~~~~~~~ vim +/BRCM_4371_FIRMWARE_BASENAME +33 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h 46d703a775394e Hante Meuleman 2015-11-25 31 41f573dbb534f1 Arend Van Spriel 2018-03-22 32 #define BRCMF_FW_DEF(fw_name, fw_base) \ 41f573dbb534f1 Arend Van Spriel 2018-03-22 @33 static const char BRCM_ ## fw_name ## _FIRMWARE_BASENAME[] = \ 41f573dbb534f1 Arend Van Spriel 2018-03-22 34 BRCMF_FW_DEFAULT_PATH fw_base; \ 41f573dbb534f1 Arend Van Spriel 2018-03-22 35 MODULE_FIRMWARE(BRCMF_FW_DEFAULT_PATH fw_base ".bin") 46d703a775394e Hante Meuleman 2015-11-25 36 885f256f61f958 Matthias Brugger 2021-06-07 37 /* Firmware and Country Local Matrix files */ 885f256f61f958 Matthias Brugger 2021-06-07 38 #define BRCMF_FW_CLM_DEF(fw_name, fw_base) \ 885f256f61f958 Matthias Brugger 2021-06-07 @39 static const char BRCM_ ## fw_name ## _FIRMWARE_BASENAME[] = \ 885f256f61f958 Matthias Brugger 2021-06-07 40 BRCMF_FW_DEFAULT_PATH fw_base; \ 885f256f61f958 Matthias Brugger 2021-06-07 41 MODULE_FIRMWARE(BRCMF_FW_DEFAULT_PATH fw_base ".bin"); \ 885f256f61f958 Matthias Brugger 2021-06-07 42 MODULE_FIRMWARE(BRCMF_FW_DEFAULT_PATH fw_base ".clm_blob") 885f256f61f958 Matthias Brugger 2021-06-07 43 -- 0-DAY CI Kernel Test Service https://01.org/lkp