From: Jesus Sanchez-Palencia <jesussanp@google.com>
To: linux-perf-users@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Ian Rogers <irogers@google.com>,
linux-kernel@vger.kernel.org,
Jesus Sanchez-Palencia <jesussanp@google.com>
Subject: [PATCH] perf: Add missing sys/types.h include
Date: Wed, 4 Jan 2023 10:23:13 -0800 [thread overview]
Message-ID: <20230104182313.3164736-1-jesussanp@google.com> (raw)
Not all libc implementations define ssize_t as part of stdio.h like
glibc does since the standard only requires this type to be defined by
unistd.h and sys/types.h. For this reason the perf build is currently
broken for toolchains based on uClibc, for instance.
Include sys/types.h explicitly to fix that. This is a follow up to
commit 378ef0f5d9d7 ("perf build: Use libtraceevent from the system").
Signed-off-by: Jesus Sanchez-Palencia <jesussanp@google.com>
---
tools/perf/util/trace-event.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h
index add6c5d9531c..9b3cd79cca12 100644
--- a/tools/perf/util/trace-event.h
+++ b/tools/perf/util/trace-event.h
@@ -4,6 +4,7 @@
#include <stdbool.h>
#include <stdio.h>
+#include <sys/types.h>
#include <linux/types.h>
struct evlist;
--
2.39.0.314.g84b9a713c41-goog
next reply other threads:[~2023-01-04 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 18:23 Jesus Sanchez-Palencia [this message]
2023-01-04 19:06 ` Ian Rogers
2023-01-04 19:13 ` Arnaldo Carvalho de Melo
2023-01-04 19:33 ` Jesus Sanchez-Palencia
2023-01-04 19:42 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104182313.3164736-1-jesussanp@google.com \
--to=jesussanp@google.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®