From: "Paul E. McKenney" <paulmck@kernel.org>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org,
sboyd@kernel.org, corbet@lwn.net, Mark.Rutland@arm.com,
maz@kernel.org, kernel-team@meta.com, neeraju@codeaurora.org,
ak@linux.intel.com, feng.tang@intel.com, zhengjun.xing@intel.com,
Yunying Sun <yunying.sun@intel.com>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH clocksource 1/6] clocksource: Print clocksource name when clocksource is tested unstable
Date: Wed, 4 Jan 2023 17:06:56 -0800 [thread overview]
Message-ID: <20230105010701.1773895-1-paulmck@kernel.org> (raw)
In-Reply-To: <20230105010429.GA1773522@paulmck-ThinkPad-P17-Gen-1>
From: Yunying Sun <yunying.sun@intel.com>
Some "TSC fall back to HPET" messages appear on systems having more than
2 NUMA nodes:
clocksource: timekeeping watchdog on CPU168: hpet read-back delay of 4296200ns, attempt 4, marking unstable
The "hpet" here is misleading the clocksource watchdog is really
doing repeated reads of "hpet" in order to check for unrelated delays.
Therefore, print the name of the clocksource under test, prefixed by
"wd-" and suffixed by "-wd", for example, "wd-tsc-wd".
Signed-off-by: Yunying Sun <yunying.sun@intel.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/time/clocksource.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 9cf32ccda715d..4a2c3bb92e2e9 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -257,8 +257,8 @@ static enum wd_read_status cs_watchdog_read(struct clocksource *cs, u64 *csnow,
goto skip_test;
}
- pr_warn("timekeeping watchdog on CPU%d: %s read-back delay of %lldns, attempt %d, marking unstable\n",
- smp_processor_id(), watchdog->name, wd_delay, nretries);
+ pr_warn("timekeeping watchdog on CPU%d: wd-%s-wd read-back delay of %lldns, attempt %d, marking unstable\n",
+ smp_processor_id(), cs->name, wd_delay, nretries);
return WD_READ_UNSTABLE;
skip_test:
--
2.31.1.189.g2e36527f23
next prev parent reply other threads:[~2023-01-05 1:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 1:04 [PATCH clocksource 0/6] Clocksource watchdog updates for v6.3 Paul E. McKenney
2023-01-05 1:06 ` Paul E. McKenney [this message]
2023-01-05 1:06 ` [PATCH clocksource 2/6] clocksource: Loosen clocksource watchdog constraints Paul E. McKenney
2023-01-05 1:06 ` [PATCH clocksource 3/6] clocksource: Improve read-back-delay message Paul E. McKenney
2023-01-05 1:06 ` [PATCH clocksource 4/6] clocksource: Improve "skew is too large" messages Paul E. McKenney
2023-01-05 1:07 ` [PATCH clocksource 5/6] clocksource: Suspend the watchdog temporarily when high read latency detected Paul E. McKenney
2023-01-11 11:26 ` Thomas Gleixner
2023-01-11 12:31 ` Feng Tang
2023-01-11 17:50 ` Paul E. McKenney
2023-01-11 21:19 ` Thomas Gleixner
2023-01-11 21:32 ` Paul E. McKenney
2023-01-12 0:59 ` Feng Tang
2023-01-05 1:07 ` [PATCH clocksource 6/6] clocksource: Verify HPET and PMTMR when TSC unverified Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105010701.1773895-1-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=Mark.Rutland@arm.com \
--cc=ak@linux.intel.com \
--cc=corbet@lwn.net \
--cc=feng.tang@intel.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=neeraju@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=yunying.sun@intel.com \
--cc=zhengjun.xing@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®