From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-serial@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: linux-kernel@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v2 0/3] serial: Separate RT288x/Au1xxx code into own file
Date: Thu, 5 Jan 2023 14:47:41 +0200 [thread overview]
Message-ID: <20230105124744.105950-1-ilpo.jarvinen@linux.intel.com> (raw)
A non-trivial amount of RT288x/Au1xxx code is encapsulated into
ifdeffery in 8250_port / 8250_early and some if/switch UPIO_AU blocks.
Create a separate file from them and do a few additional cleanups.
I kept the Kconfig entry as bool because the code has somewhat tricky
dependency chain (mips arch code and 8250_of driver). It would be nice
to make it tristate but I don't know how blocking some invalid =m + =y
combinations would be best addressed. It should probably be best done
on top of this series independent of the split itself anyway.
UPIO_AU could now be removed because it's same as UPIO_MEM for the
remaining code path but I'm unsure if that's allowed (is the port
iotype part of stable ABI or not)?
v2:
- Define register map array lengths explicitly to avoid creating
declaration trap.
Ilpo Järvinen (3):
serial: 8250: RT288x/Au1xxx code away from core
serial: 8250_rt288x: Name non-standard divisor latch reg
serial: 8250_rt288x: Remove unnecessary UART_REG_UNMAPPED
arch/mips/alchemy/common/platform.c | 10 +-
drivers/tty/serial/8250/8250_core.c | 4 +
drivers/tty/serial/8250/8250_early.c | 21 ----
drivers/tty/serial/8250/8250_of.c | 4 +-
drivers/tty/serial/8250/8250_port.c | 78 ---------------
drivers/tty/serial/8250/8250_rt288x.c | 135 ++++++++++++++++++++++++++
drivers/tty/serial/8250/Makefile | 1 +
include/linux/serial_8250.h | 14 ++-
8 files changed, 163 insertions(+), 104 deletions(-)
create mode 100644 drivers/tty/serial/8250/8250_rt288x.c
--
2.30.2
next reply other threads:[~2023-01-05 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 12:47 Ilpo Järvinen [this message]
2023-01-05 12:47 ` [PATCH v2 1/3] serial: 8250: RT288x/Au1xxx code away from core Ilpo Järvinen
2023-01-06 7:36 ` Jiri Slaby
2023-01-05 12:47 ` [PATCH v2 2/3] serial: 8250_rt288x: Name non-standard divisor latch reg Ilpo Järvinen
2023-01-05 12:47 ` [PATCH v2 3/3] serial: 8250_rt288x: Remove unnecessary UART_REG_UNMAPPED Ilpo Järvinen
2023-01-06 8:16 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105124744.105950-1-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=philmd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®