From: Andrew Morton <akpm@linux-foundation.org>
To: Hongchen Zhang <zhanghongchen@loongson.cn>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Kuniyuki Iwashima <kuniyu@amazon.co.jp>,
Luis Chamberlain <mcgrof@kernel.org>,
David Howells <dhowells@redhat.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Randy Dunlap <rdunlap@infradead.org>,
Eric Dumazet <edumazet@google.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pipe: use __pipe_{lock,unlock} instead of spinlock
Date: Thu, 5 Jan 2023 18:59:09 -0800 [thread overview]
Message-ID: <20230105185909.c77ce4d136279ec46a204d61@linux-foundation.org> (raw)
In-Reply-To: <20230103063303.23345-1-zhanghongchen@loongson.cn>
On Tue, 3 Jan 2023 14:33:03 +0800 Hongchen Zhang <zhanghongchen@loongson.cn> wrote:
> Use spinlock in pipe_read/write cost too much time,IMO
> pipe->{head,tail} can be protected by __pipe_{lock,unlock}.
> On the other hand, we can use __pipe_lock/unlock to protect the
> pipe->head/tail in pipe_resize_ring and post_one_notification.
Can you please test this with the test code in Linus's 0ddad21d3e99 and
check that performance is good?
next prev parent reply other threads:[~2023-01-06 2:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 6:33 Hongchen Zhang
2023-01-03 17:51 ` Matthew Wilcox
2023-01-04 3:46 ` Hongchen Zhang
2023-01-06 2:59 ` Andrew Morton [this message]
2023-01-06 7:50 ` Hongchen Zhang
2023-01-06 7:08 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105185909.c77ce4d136279ec46a204d61@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=kuniyu@amazon.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rdunlap@infradead.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zhanghongchen@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®