From: Jinyoung CHOI <j-young.choi@samsung.com>
To: Avri Altman <Avri.Altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Asutosh Das <quic_asutoshd@quicinc.com>
Cc: Johan Hovold <johan+linaro@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Can Guo <quic_cang@quicinc.com>
Subject: RE:(2) [PATCH] scsi: ufs: core: fix devfreq deadlocks
Date: Fri, 06 Jan 2023 11:24:56 +0900 [thread overview]
Message-ID: <20230106022456epcms2p784b3cf9115f6b170bdef0732258381ba@epcms2p7> (raw)
In-Reply-To: <DM6PR04MB65750DE015FA51FDC08D994BFCFA9@DM6PR04MB6575.namprd04.prod.outlook.com>
>> On 1/4/23 06:10, Asutosh Das wrote:
>> > Load based toggling of WB seemed fine to me then.
>> > I haven't thought about another method to toggle WriteBooster yet.
>> > Let me see if I can come up with something.
>> > IMT if you have a mechanism in mind, please let me know.
>>
>> Hi Asutosh,
>>
>> Which UFS devices need this mechanism? All UFS devices I'm familiar with can
>> achieve wire speed for large write requests without enabling the WriteBooster.
>This feature assures SLC-performance for writes to the WriteBooster buffer.
>So enabling it is advantageous as far as write performance.
I agree with you. Also, it can be used in various ways.
>As for the toggling functionality, compared to e.g. enabling it on init and leave it on,
>some flash vendors require it because of device health considerations.
>This is not the case for us, so let others to comment.
In our case, it does not matter whether to toggle or not.
To make the code simple, it seems to be a good way to enable it on init and leave it on.
Considering device health, WB can be disabled through lifetime check.
Thanks,
Jinyoung.
>
>Thanks,
>Avri
>>
>> Thanks,
>>
>> Bart.
next prev parent reply other threads:[~2023-01-06 2:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 10:21 Johan Hovold
2023-01-03 21:28 ` Andrew Halaney
2023-01-03 21:45 ` Bart Van Assche
2023-01-04 8:24 ` Avri Altman
2023-01-04 22:34 ` Bart Van Assche
2023-01-04 14:10 ` Asutosh Das
2023-01-04 22:31 ` Bart Van Assche
2023-01-05 7:21 ` Avri Altman
[not found] ` <CGME20230105072134epcas2p47a72da1ee48e341295575770d3eb573c@epcms2p7>
2023-01-06 2:24 ` Jinyoung CHOI [this message]
2023-01-06 14:51 ` (2) " Asutosh Das
2023-01-05 18:38 ` Bart Van Assche
2023-01-16 16:03 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106022456epcms2p784b3cf9115f6b170bdef0732258381ba@epcms2p7 \
--to=j-young.choi@samsung.com \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®