From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev,
Ajye Huang <ajye_huang@compal.corp-partner.google.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c:143 primary_codec_init() warn: missing error code? 'ret'
Date: Sat, 7 Jan 2023 11:40:30 +0300 [thread overview]
Message-ID: <202301070814.uxRqe1Ox-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1f5abbd77e2c1787e74b7c2caffac97def78ba52
commit: e14657c0f0022e02c8f25fa9c56afae3d3db9e77 ASoC: mediatek: mt8186-rt5682: Modify machine driver for two DMICs case
config: microblaze-randconfig-m041-20230106
compiler: microblaze-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c:143 primary_codec_init() warn: missing error code? 'ret'
vim +/ret +143 sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c
e14657c0f0022e Ajye Huang 2022-11-02 127 static int primary_codec_init(struct snd_soc_pcm_runtime *rtd)
e14657c0f0022e Ajye Huang 2022-11-02 128 {
e14657c0f0022e Ajye Huang 2022-11-02 129 struct snd_soc_card *card = rtd->card;
e14657c0f0022e Ajye Huang 2022-11-02 130 struct mtk_soc_card_data *soc_card_data = snd_soc_card_get_drvdata(card);
e14657c0f0022e Ajye Huang 2022-11-02 131 struct mt8186_mt6366_rt1019_rt5682s_priv *priv = soc_card_data->mach_priv;
e14657c0f0022e Ajye Huang 2022-11-02 132 int ret;
e14657c0f0022e Ajye Huang 2022-11-02 133
e14657c0f0022e Ajye Huang 2022-11-02 134 ret = mt8186_mt6366_init(rtd);
e14657c0f0022e Ajye Huang 2022-11-02 135
e14657c0f0022e Ajye Huang 2022-11-02 136 if (ret) {
e14657c0f0022e Ajye Huang 2022-11-02 137 dev_err(card->dev, "mt8186_mt6366_init failed: %d\n", ret);
e14657c0f0022e Ajye Huang 2022-11-02 138 return ret;
e14657c0f0022e Ajye Huang 2022-11-02 139 }
e14657c0f0022e Ajye Huang 2022-11-02 140
e14657c0f0022e Ajye Huang 2022-11-02 141 if (!priv->dmic_sel) {
e14657c0f0022e Ajye Huang 2022-11-02 142 dev_info(card->dev, "dmic_sel is null\n");
e14657c0f0022e Ajye Huang 2022-11-02 @143 return ret;
return -EIVNAL;? return 0;?
e14657c0f0022e Ajye Huang 2022-11-02 144 }
e14657c0f0022e Ajye Huang 2022-11-02 145
e14657c0f0022e Ajye Huang 2022-11-02 146 ret = snd_soc_dapm_new_controls(&card->dapm, dmic_widgets,
e14657c0f0022e Ajye Huang 2022-11-02 147 ARRAY_SIZE(dmic_widgets));
e14657c0f0022e Ajye Huang 2022-11-02 148 if (ret) {
e14657c0f0022e Ajye Huang 2022-11-02 149 dev_err(card->dev, "DMic widget addition failed: %d\n", ret);
e14657c0f0022e Ajye Huang 2022-11-02 150 /* Don't need to add routes if widget addition failed */
e14657c0f0022e Ajye Huang 2022-11-02 151 return ret;
e14657c0f0022e Ajye Huang 2022-11-02 152 }
e14657c0f0022e Ajye Huang 2022-11-02 153
e14657c0f0022e Ajye Huang 2022-11-02 154 ret = snd_soc_dapm_add_routes(&card->dapm, dmic_map,
e14657c0f0022e Ajye Huang 2022-11-02 155 ARRAY_SIZE(dmic_map));
e14657c0f0022e Ajye Huang 2022-11-02 156
e14657c0f0022e Ajye Huang 2022-11-02 157 if (ret)
e14657c0f0022e Ajye Huang 2022-11-02 158 dev_err(card->dev, "DMic map addition failed: %d\n", ret);
e14657c0f0022e Ajye Huang 2022-11-02 159
e14657c0f0022e Ajye Huang 2022-11-02 160 return ret;
e14657c0f0022e Ajye Huang 2022-11-02 161 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
reply other threads:[~2023-01-07 8:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301070814.uxRqe1Ox-lkp@intel.com \
--to=error27@gmail.com \
--cc=ajye_huang@compal.corp-partner.google.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®