From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6341C54EBD for ; Sun, 8 Jan 2023 17:06:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232956AbjAHRGy (ORCPT ); Sun, 8 Jan 2023 12:06:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjAHRGw (ORCPT ); Sun, 8 Jan 2023 12:06:52 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CAD6E10 for ; Sun, 8 Jan 2023 09:06:51 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id BFBD268AA6; Sun, 8 Jan 2023 18:06:48 +0100 (CET) Date: Sun, 8 Jan 2023 18:06:48 +0100 From: Christoph Hellwig To: Keith Busch Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , Tony Battersby , Kernel Team , Keith Busch Subject: Re: [PATCHv3 06/12] dmapool: move debug code to own functions Message-ID: <20230108170648.GB19739@lst.de> References: <20230103191551.3254778-1-kbusch@meta.com> <20230103191551.3254778-7-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230103191551.3254778-7-kbusch@meta.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +#ifdef DMAPOOL_DEBUG I'd drop the weird tab indent carrier over from the original code here. Also any reason to not use a single big ifdef blocked instead of multiple ones? Otherwise looks good: Reviewed-by: Christoph Hellwig