mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
	"Maciej W. Rozycki" <macro@orcam.me.uk>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 5/7] parport_pc: Add an ECR mask field for PCI devices
Date: Sun,  8 Jan 2023 21:56:54 +0000	[thread overview]
Message-ID: <20230108215656.6433-5-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <20230108215656.6433-1-sudipm.mukherjee@gmail.com>

From: "Maciej W. Rozycki" <macro@orcam.me.uk>

Add a bitmask field specifying writable ECR bits for PCI devices and
apply it via `__parport_pc_probe_port'.

Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---
 drivers/parport/parport_pc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
index 2928f36e05ff..d7e64f6dfe90 100644
--- a/drivers/parport/parport_pc.c
+++ b/drivers/parport/parport_pc.c
@@ -2662,6 +2662,10 @@ static struct parport_pc_pci {
 	/* Bit field of parport modes to exclude. */
 	unsigned int mode_mask;
 
+	/* If non-zero, sets the bitmask of writable ECR bits.  In that
+	 * case additionally bit 0 will be forcibly set on writes. */
+	unsigned char ecr_writable;
+
 	/* If set, this is called immediately after pci_enable_device.
 	 * If it returns non-zero, no probing will take place and the
 	 * ports will not be used. */
@@ -2868,7 +2872,8 @@ static int parport_pc_pci_probe(struct pci_dev *dev,
 			__parport_pc_probe_port(io_lo, io_hi, irq,
 						PARPORT_DMA_NONE, &dev->dev,
 						IRQF_SHARED,
-						cards[i].mode_mask, 0);
+						cards[i].mode_mask,
+						cards[i].ecr_writable);
 		if (data->ports[count])
 			count++;
 	}
-- 
2.30.2


  parent reply	other threads:[~2023-01-08 21:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-08 21:56 [PATCH 1/7] parport_pc: Remove stale `parport_pc_ecp_read_block_pio' reference Sudip Mukherjee
2023-01-08 21:56 ` [PATCH 2/7] parport_pc: Let chipset drivers mask unsupported modes Sudip Mukherjee
2023-01-08 21:56 ` [PATCH 3/7] parport_pc: Let chipset drivers mask ECR bits on writes Sudip Mukherjee
2023-01-08 21:56 ` [PATCH 4/7] parport_pc: Add a mode mask field for PCI devices Sudip Mukherjee
2023-01-08 21:56 ` Sudip Mukherjee [this message]
2023-01-08 21:56 ` [PATCH 6/7] parport_pc: Set up mode and ECR masks for Oxford Semiconductor devices Sudip Mukherjee
2023-01-08 21:56 ` [PATCH 7/7] parport_pc: Limit the number of PCI BAR pairs to 2 Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230108215656.6433-5-sudipm.mukherjee@gmail.com \
    --to=sudipm.mukherjee@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®