From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A880BC54EBD for ; Mon, 9 Jan 2023 13:29:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236930AbjAIN3z (ORCPT ); Mon, 9 Jan 2023 08:29:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231267AbjAIN3u (ORCPT ); Mon, 9 Jan 2023 08:29:50 -0500 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60D83BC0F; Mon, 9 Jan 2023 05:29:48 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id u19so20008961ejm.8; Mon, 09 Jan 2023 05:29:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OnLgVlQcPUmhGddpJYGzFYAsfQhj3TvV2AMn1iaicV4=; b=U0mU7RMxkmdrEdFGy9CJinO/If0ziVK7HzWZwo7R85GUyz6cSI7XQD1JoGsqiEp8tA +QcYaPpK3zPBijaX+YJd/w6l9Y1ItyCd06CMjFrOG3WZJHK15sDrIMKJgGDnWpAbA/1n X9a13cQt3BTasjrHlr+X3cWfIMcdKAKeeRp/S2sVSELPIftbUS+whnD2WERmwB6QqHe2 5o/V1B9CA4Ura/1X6EXDtpUbZiC2DYYTTxiIEE5cgG2PBCDJgsxrXPvN+CThUAbvucsc At+7UXZq/WrTJIwbwRFHnmlfji81yAHU2tpuVQFPVo7BJKxR0pzsOzGWPXQFKSVQHdBz 1YMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OnLgVlQcPUmhGddpJYGzFYAsfQhj3TvV2AMn1iaicV4=; b=B6FiHHTZ8kCeizRSNORRAoeU4yPWdcQTKVfJOZMYu9yRfioSmdDv3OczcQlO2w0e98 RDS33V9dEcAzAKdx96BIpVPeyWP/a81pLOkgPZD/cH0b21/misSkbrTLPPhoewkBeMRN WVq20zDRP2LO6cFkkmYvmryCMkkAIYcz4eo1Cb29LEwto0YD6eLMpW1bJzM+b/ihOzew bN8Vx/w9Y2SeA6BE+SrHFLVYkqRrfBe8CW8XgXGfAzAwpcZW4oy4M9SoJQSZh1pI1gTX e8DGvfyyBKTB50lHxauvR8WEwwQjWnxDffmilTpkfMdC0pJ267Efp++J6qhkCejDIeAI kD5Q== X-Gm-Message-State: AFqh2koh8exg6Tn0aAobQ/7x/1yqQOvXTFYrymDCJYYJTVF/RoGFE6Sy F6EWDIFPPcAYkc/Z3FoJZAw= X-Google-Smtp-Source: AMrXdXuk/fs7Fa0jTnCxkLCt/vvpaLyKgXMW78MxFDCX5QqZMNBLOgiPVgoxVohrUH1FftyprV4BLQ== X-Received: by 2002:a17:906:280d:b0:7c1:2a0f:55b1 with SMTP id r13-20020a170906280d00b007c12a0f55b1mr60218751ejc.14.1673270986856; Mon, 09 Jan 2023 05:29:46 -0800 (PST) Received: from skbuf ([188.27.185.38]) by smtp.gmail.com with ESMTPSA id n12-20020a1709062bcc00b007ae38d837c5sm3761223ejg.174.2023.01.09.05.29.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 05:29:46 -0800 (PST) Date: Mon, 9 Jan 2023 15:29:44 +0200 From: Vladimir Oltean To: "Hans J. Schultz" Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Eric Dumazet , Paolo Abeni , open list Subject: Re: [PATCH v4 net-next 2/3] net: dsa: mv88e6xxx: shorten the locked section in mv88e6xxx_g1_atu_prob_irq_thread_fn() Message-ID: <20230109132944.ipczdt3oj2kpfppn@skbuf> References: <20230108094849.1789162-1-netdev@kapio-technology.com> <20230108094849.1789162-3-netdev@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230108094849.1789162-3-netdev@kapio-technology.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 08, 2023 at 10:48:48AM +0100, Hans J. Schultz wrote: > As only the hardware access functions up til and including > mv88e6xxx_g1_atu_mac_read() called under the interrupt handler > need to take the chip lock, we release the chip lock after this call. > The follow up code that handles the violations can run without the > chip lock held. > In further patches, the violation handler function will even be > incompatible with having the chip lock held. This due to an AB/BA > ordering inversion with rtnl_lock(). > > Signed-off-by: Hans J. Schultz > --- Reviewed-by: Vladimir Oltean