From: Jan Kara <jack@suse.cz>
To: Zhihao Cheng <chengzhihao1@huawei.com>
Cc: tytso@mit.edu, jack@suse.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
libaokun1@huawei.com, zhanchengbin1@huawei.com
Subject: Re: [PATCH -next v3] jbd2: Fix data missing when reusing bh which is ready to be checkpointed
Date: Mon, 9 Jan 2023 16:29:23 +0100 [thread overview]
Message-ID: <20230109152923.fvx57xucg2vggzp6@quack3> (raw)
In-Reply-To: <20230109134545.2234414-1-chengzhihao1@huawei.com>
On Mon 09-01-23 21:45:45, Zhihao Cheng wrote:
> Following process will make data lost and could lead to a filesystem
> corrupted problem:
>
> 1. jh(bh) is inserted into T1->t_checkpoint_list, bh is dirty, and
> jh->b_transaction = NULL
> 2. T1 is added into journal->j_checkpoint_transactions.
> 3. Get bh prepare to write while doing checkpoing:
> PA PB
> do_get_write_access jbd2_log_do_checkpoint
> spin_lock(&jh->b_state_lock)
> if (buffer_dirty(bh))
> clear_buffer_dirty(bh) // clear buffer dirty
> set_buffer_jbddirty(bh)
> transaction =
> journal->j_checkpoint_transactions
> jh = transaction->t_checkpoint_list
> if (!buffer_dirty(bh))
> __jbd2_journal_remove_checkpoint(jh)
> // bh won't be flushed
> jbd2_cleanup_journal_tail
> __jbd2_journal_file_buffer(jh, transaction, BJ_Reserved)
> 4. Aborting journal/Power-cut before writing latest bh on journal area.
>
> In this way we get a corrupted filesystem with bh's data lost.
>
> Fix it by moving the clearing of buffer_dirty bit just before the call
> to __jbd2_journal_file_buffer(), both bit clearing and jh->b_transaction
> assignment are under journal->j_list_lock locked, so that
> jbd2_log_do_checkpoint() will wait until jh's new transaction fininshed
> even bh is currently not dirty. And journal_shrink_one_cp_list() won't
> remove jh from checkpoint list if the buffer head is reused in
> do_get_write_access().
>
> Fetch a reproducer in [Link].
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216898
> Cc: <stable@kernel.org>
> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
> Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
> Suggested-by: Jan Kara <jack@suse.cz>
Great, the patch looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Just a suggestion for rephrasing of the comment below
> - /*
> - * In any case we need to clean the dirty flag and we must
> - * do it under the buffer lock to be sure we don't race
> - * with running write-out.
> + * We need to clean the dirty flag and we must do it under the
> + * buffer lock to be sure we don't race with running write-out.
> */
> JBUFFER_TRACE(jh, "Journalling dirty buffer");
> clear_buffer_dirty(bh);
> + /*
> + * Setting jbddirty after clearing buffer dirty is necessary.
> + * Function jbd2_journal_restart() could keep buffer on
> + * BJ_Reserved list until the transaction committing, then the
> + * buffer won't be dirtied by jbd2_journal_refile_buffer()
> + * after committing, the buffer couldn't fall on disk even
> + * last checkpoint finished, which may corrupt filesystem.
> + */
As far as I understand you want to say:
/*
* The buffer is going to be added to BJ_Reserved list now
* and nothing guarantees jbd2_journal_dirty_metadata()
* will be ever called for it. So we need to set jbddirty
* bit here to make sure the buffer is dirtied and written
* out when the journaling machinery is done with it.
*/
> set_buffer_jbddirty(bh);
> }
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-01-09 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 13:45 Zhihao Cheng
2023-01-09 15:29 ` Jan Kara [this message]
2023-01-10 1:17 ` Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109152923.fvx57xucg2vggzp6@quack3 \
--to=jack@suse.cz \
--cc=chengzhihao1@huawei.com \
--cc=jack@suse.com \
--cc=libaokun1@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
--cc=zhanchengbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®