From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72CEDC61DB3 for ; Mon, 9 Jan 2023 19:22:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235249AbjAITWg (ORCPT ); Mon, 9 Jan 2023 14:22:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234934AbjAITWb (ORCPT ); Mon, 9 Jan 2023 14:22:31 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 221436C2BE; Mon, 9 Jan 2023 11:22:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D44C61115; Mon, 9 Jan 2023 19:22:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCC67C433EF; Mon, 9 Jan 2023 19:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673292148; bh=htbtetKp6LvDEmtxfygdNB2SYbLgZM+2mVnnjewbqS4=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=Au6Y+DeU+7zTdmR/w13Bb2913aWfnKsrBWT0WL1Y3humfk2O8vXhFYp79RSotXbeO UyA5cheMgKBO9b7e8zwAffWSNfK4JxvxGqoR76OjH9KY66SzDyhFppU39clTt4MaiC qdRyxEhFg6DtGiHRp3jWinivHMTG8QYQe2NnenFmxXniV81gj2w3TxzfrP2eL4J+bl p3/55maqNVSYx+05YCUYY0qUAwPMGCF6z7XJ2CVIZz9fhAnO1Je5mjinxq9OTCNEX6 Jf8n4BNeHBZXif/YbFp+0DEKuVrGf++Gw8sfTHQw8y3fqwZT7iq1kEzZrHqnQ6V+VY tGsnWVp5c+L2Q== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 78CF65C05C8; Mon, 9 Jan 2023 11:22:28 -0800 (PST) Date: Mon, 9 Jan 2023 11:22:28 -0800 From: "Paul E. McKenney" To: Sean Christopherson Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, rostedt@goodmis.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , x86@kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH rcu 01/27] arch/x86: Remove "select SRCU" Message-ID: <20230109192228.GV4028633@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20230105003759.GA1769545@paulmck-ThinkPad-P17-Gen-1> <20230105003813.1770367-1-paulmck@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2023 at 05:43:23PM +0000, Sean Christopherson wrote: > On Wed, Jan 04, 2023, Paul E. McKenney wrote: > > Now that the SRCU Kconfig option is unconditionally selected, there is > > no longer any point in selecting it. Therefore, remove the "select SRCU" > > Kconfig statements. > > > > Signed-off-by: Paul E. McKenney > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: Borislav Petkov > > Cc: Dave Hansen > > Cc: "H. Peter Anvin" > > Cc: Sean Christopherson > > Cc: Paolo Bonzini > > Cc: > > Cc: > > --- > > ... > > > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig > > index fbeaa9ddef598..9306d99585188 100644 > > --- a/arch/x86/kvm/Kconfig > > +++ b/arch/x86/kvm/Kconfig > > @@ -46,7 +46,6 @@ config KVM > > select KVM_XFER_TO_GUEST_WORK > > select KVM_GENERIC_DIRTYLOG_READ_PROTECT > > select KVM_VFIO > > - select SRCU > > Would it be too much trouble to bundle all of the KVM changes into a single patch? > The SRCU requirement is a generic KVM requirement that's handled in the arch Kconfigs > purely because of KVM's somewhat roundabout Kconfig setup. No problem, and will do on my next rebase. I might end up with a long list of Cc's, but so it goes. I will of course send the result as a reply to this message. Thanx, Paul > > select INTERVAL_TREE > > select HAVE_KVM_PM_NOTIFIER if PM > > help > > -- > > 2.31.1.189.g2e36527f23 > >