From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 3/4] staging: r8188eu: remove unused function parameter
Date: Tue, 10 Jan 2023 21:56:25 +0100 [thread overview]
Message-ID: <20230110205626.183516-4-martin@kaiser.cx> (raw)
In-Reply-To: <20230110205626.183516-1-martin@kaiser.cx>
The regs parameter of the usb_write_port_complete function is not used. We
can remove it.
We can also remove the macro to hide the regs parameter when
usb_write_port_complete is used as callback function for an urb transfer.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/include/usb_ops_linux.h | 2 --
drivers/staging/r8188eu/os_dep/usb_ops_linux.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/r8188eu/include/usb_ops_linux.h b/drivers/staging/r8188eu/include/usb_ops_linux.h
index 966688eedf66..e406a1fccda7 100644
--- a/drivers/staging/r8188eu/include/usb_ops_linux.h
+++ b/drivers/staging/r8188eu/include/usb_ops_linux.h
@@ -19,8 +19,6 @@
usb_bulkout_zero_complete(purb)
#define usb_write_mem_complete(purb, regs) \
usb_write_mem_complete(purb)
-#define usb_write_port_complete(purb, regs) \
- usb_write_port_complete(purb)
#define usb_read_port_complete(purb, regs) \
usb_read_port_complete(purb)
#define usb_read_interrupt_complete(purb, regs) \
diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
index 7da13b87d726..3fd080091340 100644
--- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
+++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
@@ -35,7 +35,7 @@ void rtw_read_port_cancel(struct adapter *padapter)
}
}
-static void usb_write_port_complete(struct urb *purb, struct pt_regs *regs)
+static void usb_write_port_complete(struct urb *purb)
{
struct xmit_buf *pxmitbuf = (struct xmit_buf *)purb->context;
struct adapter *padapter = pxmitbuf->padapter;
--
2.30.2
next prev parent reply other threads:[~2023-01-10 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 20:56 [PATCH 0/4] staging: r8188eu: clean up usb_write_port_complete Martin Kaiser
2023-01-10 20:56 ` [PATCH 1/4] staging: r8188eu: refactor status handling in usb_write_port_complete Martin Kaiser
2023-01-10 20:56 ` [PATCH 2/4] staging: r8188eu: reformat usb_write_port_complete Martin Kaiser
2023-01-10 20:56 ` Martin Kaiser [this message]
2023-01-10 20:56 ` [PATCH 4/4] staging: r8188eu: always process urb status Martin Kaiser
2023-01-11 17:24 ` Pavel Skripkin
2023-01-23 20:04 ` Martin Kaiser
2023-01-10 21:26 ` [PATCH 0/4] staging: r8188eu: clean up usb_write_port_complete Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110205626.183516-4-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®