mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chengming Zhou <zhouchengming@bytedance.com>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chengming Zhou <zhouchengming@bytedance.com>
Subject: [PATCH] fs/pipe: Delete unused do_pipe_flags()
Date: Wed, 11 Jan 2023 11:05:47 +0800	[thread overview]
Message-ID: <20230111030547.7730-1-zhouchengming@bytedance.com> (raw)

It looks like do_pipe_flags() is not used anywhere and not exported
too, so delete it. No any functional changes.

Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
 fs/pipe.c          | 11 -----------
 include/linux/fs.h |  1 -
 2 files changed, 12 deletions(-)

diff --git a/fs/pipe.c b/fs/pipe.c
index 42c7ff41c2db..9b6d7b6658f1 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -986,17 +986,6 @@ static int __do_pipe_flags(int *fd, struct file **files, int flags)
 	return error;
 }
 
-int do_pipe_flags(int *fd, int flags)
-{
-	struct file *files[2];
-	int error = __do_pipe_flags(fd, files, flags);
-	if (!error) {
-		fd_install(fd[0], files[0]);
-		fd_install(fd[1], files[1]);
-	}
-	return error;
-}
-
 /*
  * sys_pipe() is the normal C calling standard for creating
  * a pipe. It's not the way Unix traditionally does this, though.
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 452700c5fa1d..0b8fe4243f48 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3014,7 +3014,6 @@ static inline void i_readcount_inc(struct inode *inode)
 	return;
 }
 #endif
-extern int do_pipe_flags(int *, int);
 
 extern ssize_t kernel_read(struct file *, void *, size_t, loff_t *);
 ssize_t __kernel_read(struct file *file, void *buf, size_t count, loff_t *pos);
-- 
2.37.2


             reply	other threads:[~2023-01-11  3:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11  3:05 Chengming Zhou [this message]
2023-01-11  3:14 ` Al Viro
2023-01-11  7:54 ` kernel test robot
2023-01-11 10:26 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230111030547.7730-1-zhouchengming@bytedance.com \
    --to=zhouchengming@bytedance.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®