From: shravan kumar <shravan.chippa@microchip.com>
To: <paul.j.murphy@intel.com>, <daniele.alessandrelli@intel.com>,
<mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"shravan kumar" <shravan.chippa@microchip.com>,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: [PATCH v9 4/4] media: i2c: imx334: update pixel and link frequency
Date: Fri, 13 Jan 2023 06:31:35 +0530 [thread overview]
Message-ID: <20230113010135.2620818-5-shravan.chippa@microchip.com> (raw)
In-Reply-To: <20230113010135.2620818-1-shravan.chippa@microchip.com>
From: Shravan Chippa <shravan.chippa@microchip.com>
Update pixel_rate and link frequency for 1920x1080@30
while changing mode.
Add dummy ctrl cases for pixel_rate and link frequency
to avoid error while changing the modes dynamically
Suggested-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
---
drivers/media/i2c/imx334.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index 4ab1b9eb9a64..373022fbd6b2 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -49,7 +49,8 @@
#define IMX334_INCLK_RATE 24000000
/* CSI2 HW configuration */
-#define IMX334_LINK_FREQ 891000000
+#define IMX334_LINK_FREQ_891M 891000000
+#define IMX334_LINK_FREQ_445M 445500000
#define IMX334_NUM_DATA_LANES 4
#define IMX334_REG_MIN 0x00
@@ -144,7 +145,8 @@ struct imx334 {
};
static const s64 link_freq[] = {
- IMX334_LINK_FREQ,
+ IMX334_LINK_FREQ_891M,
+ IMX334_LINK_FREQ_445M,
};
/* Sensor mode registers */
@@ -468,7 +470,7 @@ static const struct imx334_mode supported_modes[] = {
.vblank_min = 45,
.vblank_max = 132840,
.pclk = 297000000,
- .link_freq_idx = 0,
+ .link_freq_idx = 1,
.reg_list = {
.num_of_regs = ARRAY_SIZE(mode_1920x1080_regs),
.regs = mode_1920x1080_regs,
@@ -598,6 +600,11 @@ static int imx334_update_controls(struct imx334 *imx334,
if (ret)
return ret;
+ ret = __v4l2_ctrl_modify_range(imx334->pclk_ctrl, mode->pclk,
+ mode->pclk, 1, mode->pclk);
+ if (ret)
+ return ret;
+
ret = __v4l2_ctrl_modify_range(imx334->hblank_ctrl, mode->hblank,
mode->hblank, 1, mode->hblank);
if (ret)
@@ -698,6 +705,8 @@ static int imx334_set_ctrl(struct v4l2_ctrl *ctrl)
pm_runtime_put(imx334->dev);
break;
+ case V4L2_CID_PIXEL_RATE:
+ case V4L2_CID_LINK_FREQ:
case V4L2_CID_HBLANK:
ret = 0;
break;
@@ -1102,7 +1111,7 @@ static int imx334_parse_hw_config(struct imx334 *imx334)
}
for (i = 0; i < bus_cfg.nr_of_link_frequencies; i++)
- if (bus_cfg.link_frequencies[i] == IMX334_LINK_FREQ)
+ if (bus_cfg.link_frequencies[i] == IMX334_LINK_FREQ_891M)
goto done_endpoint_free;
ret = -EINVAL;
--
2.34.1
next prev parent reply other threads:[~2023-01-13 1:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 1:01 [PATCH v9 0/4] media: i2c: imx334: support lower bandwidth mode shravan kumar
2023-01-13 1:01 ` [PATCH v9 1/4] media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to __v4l2_ctrl_modify_range shravan kumar
2023-01-13 8:33 ` Jacopo Mondi
2023-01-13 1:01 ` [PATCH v9 2/4] media: i2c: imx334: add missing reset values for mode 3840x2160_regs[] shravan kumar
2023-01-13 8:36 ` Jacopo Mondi
2023-01-13 1:01 ` [PATCH v9 3/4] media: i2c: imx334: support lower bandwidth mode shravan kumar
2023-01-13 8:54 ` Jacopo Mondi
2023-01-13 1:01 ` shravan kumar [this message]
2023-01-13 9:31 ` [PATCH v9 4/4] media: i2c: imx334: update pixel and link frequency Jacopo Mondi
2023-01-14 11:37 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113010135.2620818-5-shravan.chippa@microchip.com \
--to=shravan.chippa@microchip.com \
--cc=daniele.alessandrelli@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®