From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAD42C54EBD for ; Fri, 13 Jan 2023 07:27:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240737AbjAMH1a (ORCPT ); Fri, 13 Jan 2023 02:27:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240835AbjAMH05 (ORCPT ); Fri, 13 Jan 2023 02:26:57 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CDEA5AC6B for ; Thu, 12 Jan 2023 23:22:58 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id az20so31177263ejc.1 for ; Thu, 12 Jan 2023 23:22:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lWuYYVoSqXot/DOZI+j//EtGO8VULweHV3rtUrUQKts=; b=ja86f1GwueYMphnLJRJI+y8gdBDP53NwgFZ00T5Q3TkwtUQb4qfUWt1B00i9SggGUK INLTM0VaHEXQnm5mC9Y837MkP0AiDrUQl2LLpRdw6SE4zYa3z4p48is+LkXAvh5tCzqP RxKbu+Oy51lmZCKiVs9piG7eKrdmGOHcT2cCDYlSAwTPi4Qj2Z6/fx5/A6+hFvJKsoWJ 2bAe6zqPvgqcpAZsDbjDlHXUu11YG/tYcWS8F5/qhHWhThlN3hJFt5ZvJe3d7xfnQuFP lL3t5i2cvnQqyfFZMJq9psHOOdXeRzlEvO0M0GBzPjVxEmfoXL7xM0BxsGigja0nNv5q bxbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lWuYYVoSqXot/DOZI+j//EtGO8VULweHV3rtUrUQKts=; b=dAuCCQDG7eiMdipQsCxpdBWI88kzZ0ml8Jg3u4qY4smp+/mx6o7CrWMLwAs1ROra/S pjtlCuDM4ro2NhxjJObLf3qoXWNxuelVJL4OozAWxwJpnE3KrWgqyHkSNVn95SBYtzbM BeLOsfPjAMr2CFIXReicoPsWjXxPZlCiMCL0+ahnXxqjmjk6r6GVFCgLFc37sN0Y0Baf fxfV86uRmP5xbsKCF2dyEZbtY1J+ur1BFHjRc/TW9vB+L//lzLik7s+Q0mE0zOSKdjVl uvrmzwhhVN59/0Qw6PqrlNIrrtYeq75gmLB2LrIF79XdDABGTJZNmjIR5GJzOR+AemI3 U7Xw== X-Gm-Message-State: AFqh2kp/Pxeb6MYz3SP9arO2OdVmwWqtKFvD1SOp7WAP4XzcIszKcLhp 0/zBRGhXZeBykBtgB2WREq8uUg== X-Google-Smtp-Source: AMrXdXst/nbGaFkV7tpr0xcLPzua3V2BMbolci8e6vxk00MeX1OaHUgkB3WAdHNwxahT4gB0JunbNw== X-Received: by 2002:a17:907:c70b:b0:7c0:e535:13fd with SMTP id ty11-20020a170907c70b00b007c0e53513fdmr71184178ejc.70.1673594577254; Thu, 12 Jan 2023 23:22:57 -0800 (PST) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id q1-20020a17090676c100b007c0d4d3a0c1sm8262849ejn.32.2023.01.12.23.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 23:22:56 -0800 (PST) Date: Fri, 13 Jan 2023 08:22:55 +0100 From: Andrew Jones To: Atish Kumar Patra Cc: linux-kernel@vger.kernel.org, Anup Patel , Atish Patra , Guo Ren , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Rutland , Palmer Dabbelt , Paul Walmsley , Sergey Matyukevich , Eric Lin , Will Deacon Subject: Re: [PATCH v2 01/11] RISC-V: Define helper functions expose hpm counter width and count Message-ID: <20230113072255.34cnyautbwiy25p5@orel> References: <20221215170046.2010255-1-atishp@rivosinc.com> <20221215170046.2010255-2-atishp@rivosinc.com> <20230112100608.d7tnvhbotjfctlgk@orel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2023 at 10:18:05AM -0800, Atish Kumar Patra wrote: > On Thu, Jan 12, 2023 at 2:06 AM Andrew Jones wrote: > > > > On Thu, Dec 15, 2022 at 09:00:36AM -0800, Atish Patra wrote: ... > > > +EXPORT_SYMBOL(riscv_pmu_get_hpm_info); > > > > EXPORT_SYMBOL_GPL ? > > > > Is that mandatory ? I have seen usage of both in arch/riscv and other > places though. > I am also not sure if any other non-GPL module should/need access to this. TBH, I'm not sure what the best policy is, but I presumed we should use _GPL when we aren't aware of anything non-GPL and then when a day comes that something non-GPL would like this to be exported, the patch that flips it will provide the justification in its commit message. Thanks, drew