From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF139C63797 for ; Sun, 15 Jan 2023 16:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231469AbjAOQdE (ORCPT ); Sun, 15 Jan 2023 11:33:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231197AbjAOQc7 (ORCPT ); Sun, 15 Jan 2023 11:32:59 -0500 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8A7DC64E; Sun, 15 Jan 2023 08:32:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=T4etuF3fqWD3zYNvu+FNCk5e1+phUaWKtANCgu8gUIM=; b=FiGiKfahqnN5hNp006hZkJBe4d dr49K+/LZq1NXlPkNKDfUnMXtEctty+m3NrLFQ5BOj1AhoGwubCOswRYnyGzYXg6MaoChIWjGBpWn pQt9smnww+6VWmWFcVK6I4D9/kq6QHmL2v09/P3O1ASIvAOlocJoV702EbMoD+OaZU9I=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:41196 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1pH5wB-0007rh-6P; Sun, 15 Jan 2023 11:32:52 -0500 Date: Sun, 15 Jan 2023 11:32:50 -0500 From: Hugo Villeneuve To: Jonathan Cameron Cc: Krzysztof Kozlowski , hvilleneuve@dimonoff.com, lars@metafoo.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <20230115113250.d8a0ec5a2638e24c1208539c@hugovil.com> In-Reply-To: <20230115164326.7f03f6d9@jic23-huawei> References: <20230113194959.3276433-1-hugo@hugovil.com> <20230113194959.3276433-3-hugo@hugovil.com> <20230115112205.e46ab8d017b99dd987d003e4@hugovil.com> <20230115164326.7f03f6d9@jic23-huawei> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH v3 2/2] dt-bindings: iio: adc: add Texas Instruments ADS7924 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 15 Jan 2023 16:43:26 +0000 Jonathan Cameron wrote: > On Sun, 15 Jan 2023 11:22:05 -0500 > Hugo Villeneuve wrote: > > > On Sun, 15 Jan 2023 15:57:21 +0100 > > Krzysztof Kozlowski wrote: > > > > > On 13/01/2023 20:49, Hugo Villeneuve wrote: > > > > From: Hugo Villeneuve > > > > > > > > Add device tree bindings document for the Texas Instruments ADS7924 > > > > ADC. > > > > > > > > Signed-off-by: Hugo Villeneuve > > > > --- > > > > .../bindings/iio/adc/ti,ads7924.yaml | 112 ++++++++++++++++++ > > > > 1 file changed, 112 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > > > > new file mode 100644 > > > > index 000000000000..24bbf95383b4 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > > > > @@ -0,0 +1,112 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/iio/adc/ti,ads7924.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: TI ADS7924 4 channels 12 bits I2C analog to digital converter > > > > + > > > > +maintainers: > > > > + - Hugo Villeneuve > > > > + > > > > +description: | > > > > + Texas Instruments ADS7924 4 channels 12 bits I2C analog to digital converter > > > > + > > > > + Specifications: > > > > + https://www.ti.com/lit/gpn/ads7924 > > > > + > > > > +properties: > > > > + compatible: > > > > + const: ti,ads7924 > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + vref-supply: > > > > + description: > > > > + The regulator supply for the ADC reference voltage (AVDD) > > > > + > > > > + reset-gpios: > > > > + maxItems: 1 > > > > + > > > > + interrupts: > > > > + maxItems: 1 > > > > + > > > > + "#address-cells": > > > > + const: 1 > > > > + > > > > + "#size-cells": > > > > + const: 0 > > > > + > > > > + "#io-channel-cells": > > > > + const: 1 > > > > + > > > > +patternProperties: > > > > + "^channel@[0-3]+$": > > > > + $ref: adc.yaml > > > > + > > > > + description: | > > > > + Represents the external channels which are connected to the ADC. > > > > + > > > > + properties: > > > > + reg: > > > > + description: | > > > > + The channel number. It can have up to 4 channels numbered from 0 to 3. > > > > + items: > > > > + - minimum: 0 > > > > + maximum: 3 > > > > + > > > > + label: > > > > + description: | > > > > + Unique name to identify the channel. > > > > > > Drop description, it's coming from adc.yaml. Just "label: true" > > > > Done. > > > > > > + > > > > + required: > > > > + - reg > > > > + > > > > + additionalProperties: false > > > > > > You are not allowing anything else from adc.yaml. Is it on purpose? > > > > I am really not an expert with this Yaml stuff, and reading the documentation makes me probably more confused than before reading it :) > > > > But one thing that is for sure is that these other properties in adc.yaml are not used in my driver: > > > > bipolar > > diff-channels > > settling-time-us > > oversampling-ratio > > > > So is it Ok then to use "additionalProperties: false"? I think so, but what is your recommandation? > > Makes sense to me. Whilst there are lots of things a channel can support, most > of them are hardware related and not universal. Ok, I think I am finally beginning to see the light here :) So I will then leave "additionalProperties: false". I will send a V4 soon with all the latest changes. Thank you, Hugo. > Jonathan > > > > > Thank you, > > Hugo. > > > > > > > > + > > > > +additionalProperties: false > > > > + > > > > +required: > > > > + - compatible > > > > + - reg > > > > + - vref-supply > > > > + - "#address-cells" > > > > + - "#size-cells" > > > > + > > > > > > Best regards, > > > Krzysztof > > > > > > > > > > > > -- Hugo Villeneuve