From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53341C32793 for ; Wed, 18 Jan 2023 18:10:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbjARSKY (ORCPT ); Wed, 18 Jan 2023 13:10:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231393AbjARSJx (ORCPT ); Wed, 18 Jan 2023 13:09:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56F0B4ED0C; Wed, 18 Jan 2023 10:09:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0A0FCB81E13; Wed, 18 Jan 2023 18:09:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9721C433D2; Wed, 18 Jan 2023 18:09:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674065369; bh=5pgmP1P8QMML9UWJonanxl6exLIq+UTuWfh1kpgwlMQ=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=OYJ/6BjV5zvb3qTyeNhOmHfwQEXdWLGHzwnfS9uTfzzqTptvGNfo7WXHAaQVBYczW lTluE8eWeI5V3JV9WEn6mLFmuEAdIKv7yD7/V7bF1bVDsiWJBMgiwK1BLUj94QVmdV 9QzrR67GHiLb3jyNbKFFPi/ivxkIZMwkHd/LnxSZbyDbWsBGQRHHNWWkdEaQ8U94FL zF/DG0VokbF9ptUlghNLUf3JbtjdlOZo3efFXBvdHAIHVtfJnCIcOj0FA9Ute0eRj2 nAnA0iOmt6Cm0eNMLy91jiUfC5A3k/5UHIiNYOBXdrn5Tz8h3c9HKuZlaGH4gz+QJK GPfoqMneLxP7g== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 3FF0B5C0920; Wed, 18 Jan 2023 10:09:29 -0800 (PST) Date: Wed, 18 Jan 2023 10:09:29 -0800 From: "Paul E. McKenney" To: Paul =?iso-8859-1?Q?Heidekr=FCger?= Cc: Alan Stern , Andrea Parri , Will Deacon , Peter Zijlstra , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , Akira Yokosawa , Daniel Lustig , Joel Fernandes , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, llvm@lists.linux.dev, Marco Elver , Charalampos Mainas , Pramod Bhatotia , Soham Shakraborty , Martin Fink Subject: Re: Broken Address Dependency in mm/ksm.c::cmp_and_merge_page() Message-ID: <20230118180929.GE2948950@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20220426203254.GJ4285@paulmck-ThinkPad-P17-Gen-1> <20220531150312.GH1790663@paulmck-ThinkPad-P17-Gen-1> <0EC00B0E-554A-4BF3-B012-ED1E36B12FD1@tum.de> <9E7A62DD-D5DC-4B9C-A592-1A626482563B@tum.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9E7A62DD-D5DC-4B9C-A592-1A626482563B@tum.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2023 at 11:42:23AM +0100, Paul Heidekrüger wrote: > On 13 Jan 2023, at 16:22, Alan Stern wrote: > > > On Fri, Jan 13, 2023 at 12:11:25PM +0100, Paul Heidekrüger wrote: > >> Hi all, > >> > >> FWIW, here are two more broken address dependencies, both very similar to the > >> one discussed in this thread. From what I can tell, both are protected by a > >> lock, so, again, nothing to worry about right now? Would you agree? > > > > FWIW, my opinion is that in both cases the broken dependency can be > > removed entirely. > > > >> Comments marked with "AD:" were added by me for readability. > >> > >> 1. drivers/hwtracing/stm/core.c::1050 - 1085 > >> > >> /** > >> * __stm_source_link_drop() - detach stm_source from an stm device > >> * @src: stm_source device > >> * @stm: stm device > >> * > >> * If @stm is @src::link, disconnect them from one another and put the > >> * reference on the @stm device. > >> * > >> * Caller must hold stm::link_mutex. > >> */ > >> static int __stm_source_link_drop(struct stm_source_device *src, > >> struct stm_device *stm) > >> { > >> struct stm_device *link; > >> int ret = 0; > >> > >> lockdep_assert_held(&stm->link_mutex); > >> > >> /* for stm::link_list modification, we hold both mutex and spinlock */ > >> spin_lock(&stm->link_lock); > >> spin_lock(&src->link_lock); > >> > >> /* AD: Beginning of the address dependency. */ > >> link = srcu_dereference_check(src->link, &stm_source_srcu, 1); > >> > >> /* > >> * The linked device may have changed since we last looked, because > >> * we weren't holding the src::link_lock back then; if this is the > >> * case, tell the caller to retry. > >> */ > >> if (link != stm) { > >> ret = -EAGAIN; > >> goto unlock; > >> } > >> > >> /* AD: Compiler deduces that "link" and "stm" are exchangeable at this point. */ > >> stm_output_free(link, &src->output); list_del_init(&src->link_entry); > >> > >> /* AD: Leads to WRITE_ONCE() to (&link->dev)->power.last_busy. */ > >> pm_runtime_mark_last_busy(&link->dev); > > > > In both of these statements, link can safely be replaced by stm. > > > > (There's also a control dependency which the LKMM isn't aware of. This > > makes it all the more safe.) > > > >> 2. kernel/locking/lockdep.c::6319 - 6348 > >> > >> /* > >> * Unregister a dynamically allocated key. > >> * > >> * Unlike lockdep_register_key(), a search is always done to find a matching > >> * key irrespective of debug_locks to avoid potential invalid access to freed > >> * memory in lock_class entry. > >> */ > >> void lockdep_unregister_key(struct lock_class_key *key) > >> { > >> struct hlist_head *hash_head = keyhashentry(key); > >> struct lock_class_key *k; > >> struct pending_free *pf; > >> unsigned long flags; > >> bool found = false; > >> > >> might_sleep(); > >> > >> if (WARN_ON_ONCE(static_obj(key))) > >> return; > >> > >> raw_local_irq_save(flags); > >> lockdep_lock(); > >> > >> /* AD: Address dependency begins here with an rcu_dereference_raw() into k. */ > >> hlist_for_each_entry_rcu(k, hash_head, hash_entry) { > >> /* AD: Compiler deduces that k and key are exchangable iff the if condition evaluates to true. > >> if (k == key) { > >> /* AD: Leads to WRITE_ONCE() to (&k->hash_entry)->pprev. */ > >> hlist_del_rcu(&k->hash_entry); > > > > And here k could safely be replaced with key. (And again there is a > > control dependency, but this is one that the LKMM would detect.) > > Ha, I didn't even notice the control dependencies - of course! In that case, > this doesn't warrant a patch though, given that nothing is really breaking? Up to the maintainers, but if any of the code that I maintain was relying on a control dependency, I would want that code commented. But in this case, lockdep_unregister_key() isn't called very often, correct? If so, and if this control dependency really is relied on, perhaps some stronger and less fragile ordering should be used. But again, maintainers' choice! Thanx, Paul