From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F98C004D4 for ; Thu, 19 Jan 2023 10:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230426AbjASKfI (ORCPT ); Thu, 19 Jan 2023 05:35:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230347AbjASKeb (ORCPT ); Thu, 19 Jan 2023 05:34:31 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CF006F32B for ; Thu, 19 Jan 2023 02:33:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C707B61511 for ; Thu, 19 Jan 2023 10:33:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CD1CC433D2; Thu, 19 Jan 2023 10:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674124435; bh=FSTb7ps69bklSNTl2tXp872NF4+kDIeeWJq6EUM+gQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kqDqPevZQ4XSsi7+3j4KXbs/udOIaV72oY3M/upUjyTkZVRyb8Svnwr3nY1nRv5E2 DptSYerO5xOVbpK3gXlz+pkd9ItIywRQ8CRlyjNfIdn3Hn9dP5mbaMiiRmNB8rnxrr YqBbDf2XjaKav81W1Us7rdYVdWc424fwSuTBBudRXIjlOmWcMccxm5ejjKsF9WNxyG D3Sv12PzfflJENNniy5NwIZ0SEUEsi0+Rw9xooSUgezbku9n2iJ7mpLsZE563G7w5B 0wwLkKKO1fqLNbOceGikTfJkIkoXeqq8P17mOlu+jiyAWOqnoLn2Q/jlIzEw9U0Dw/ jq75wUiw7iURA== From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: Tomer Tayar Subject: [PATCH 08/10] habanalabs: run error handling if scrub_device_mem fails after reset Date: Thu, 19 Jan 2023 12:33:37 +0200 Message-Id: <20230119103339.718430-8-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230119103339.718430-1-ogabbay@kernel.org> References: <20230119103339.718430-1-ogabbay@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomer Tayar If device memory scrubbing from hl_device_reset() fails, we return with an error code but not perform error handling code. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c index 9a9c494b08a4..edeec35fd9c6 100644 --- a/drivers/accel/habanalabs/common/device.c +++ b/drivers/accel/habanalabs/common/device.c @@ -1738,7 +1738,7 @@ int hl_device_reset(struct hl_device *hdev, u32 flags) rc = hdev->asic_funcs->scrub_device_mem(hdev); if (rc) { dev_err(hdev->dev, "scrub mem failed from device reset (%d)\n", rc); - return rc; + goto out_err; } spin_lock(&hdev->reset_info.lock); -- 2.25.1