From: "Michał Grzelak" <mchl.grzlk@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
kuninori.morimoto.gx@renesas.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org,
"Michał Grzelak" <mchl.grzlk@gmail.com>
Subject: [PATCH] dt-bindings: sound: audio-graph-port: Add capture and playback
Date: Fri, 20 Jan 2023 02:17:44 +0100 [thread overview]
Message-ID: <20230120011744.550701-1-mchl.grzlk@gmail.com> (raw)
Running 'make DT_SCHEMA_FILES=renesas,rsnd.yaml dt_binding_check'
gives following warning:
bindings/sound/renesas,rsnd.example.dtb:
sound@ec500000: port:endpoint: Unevaluated properties are not allowed
('capture', 'playback' were unexpected)
From schema: bindings/sound/renesas,rsnd.yaml
Running 'make ARCH=arm64 DT_SCHEMA_FILES=renesas,rsnd.yaml dtbs_check'
gives 140 warnings presented under tag [WARNINGS].
Fix all of them by allowing capture and playback in subnode 'endpoint'
in sound/audio-graph-port.yaml.
While editing audio-graph-port.yaml, drop quotes after referencing some
schemas.
Regarding files referencing audio-graph-port.yaml, no new errors were
observed after applying this change, tested with DT_SCHEMA_FILES set to:
marvell,mmp-sspa.yaml nvidia,tegra186-asrc.yaml
nvidia,tegra186-dspk.yaml nvidia,tegra210-admaif.yaml
nvidia,tegra210-adx.yaml nvidia,tegra210-ahub.yaml
nvidia,tegra210-amx.yaml nvidia,tegra210-dmic.yaml
nvidia,tegra210-i2s.yaml nvidia,tegra210-mixer.yaml
nvidia,tegra210-mvc.yaml nvidia,tegra210-ope.yaml
nvidia,tegra210-sfc.yaml renesas,rsnd.yaml
sgtl5000.yaml socionext,uniphier-aio.yaml
socionext,uniphier-evea.yaml st,stm32-sai.yaml
wlf,wm8962.yaml
[WARNINGS]:
sound@ec500000: ports:port:endpoint: Unevaluated properties are not
allowed ('capture', 'playback' were unexpected)
arch/arm64/boot/dts/renesas/r8a77995-draak.dtb
sound@ec500000: ports:port@0:endpoint: Unevaluated properties are not
allowed ('capture', 'playback' were unexpected)
arch/arm64/boot/dts/renesas/r8a774a1-beacon-rzg2m-kit.dtb
arch/arm64/boot/dts/renesas/r8a774b1-beacon-rzg2n-kit.dtb
arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77950-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77950-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77951-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77951-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77960-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77960-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77960-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77960-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77961-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77961-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a779m5-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a779m3-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a779m3-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a779m3-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a779m1-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a779m1-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77965-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77965-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77961-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a774e1-beacon-rzg2h-kit.dtb
sound@ec500000: ports:port@1:endpoint: Unevaluated properties are not
allowed ('playback' was unexpected)
arch/arm64/boot/dts/renesas/r8a774a1-beacon-rzg2m-kit.dtb
arch/arm64/boot/dts/renesas/r8a774b1-beacon-rzg2n-kit.dtb
arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77950-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77950-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77951-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77951-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77960-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77960-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a779m5-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a779m3-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a779m3-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77960-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77960-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77961-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77961-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77961-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77965-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77965-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a779m1-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a779m1-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a779m3-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a774e1-beacon-rzg2h-kit.dtb
sound@ec500000: ports:port@2:endpoint: Unevaluated properties are not
allowed ('playback' was unexpected)
arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77950-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77951-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77960-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77961-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77965-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a779m1-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a779m3-ulcb-kf.dtb
sound@ec500000: ports:port@3:endpoint: Unevaluated properties are not
allowed ('capture' was unexpected)
arch/arm64/boot/dts/renesas/r8a77950-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77960-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77961-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77965-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a779m1-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a779m3-ulcb-kf.dtb
sound@ec500000: port:endpoint: Unevaluated properties are not allowed
('playback' was unexpected)
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-mipi-2.1.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2-ex-idk-1110wr.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2-ex.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-ex.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-ex-idk-1110wr.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-ex-mipi-2.1.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb
arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dtb
arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex.dtb
arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-idk-1110wr.dtb
arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-mipi-2.1.dtb
sound@ec500000: Unevaluated properties are not allowed ('ports' was
unexpected)
arch/arm64/boot/dts/renesas/r8a774a1-beacon-rzg2m-kit.dtb
arch/arm64/boot/dts/renesas/r8a774e1-beacon-rzg2h-kit.dtb
arch/arm64/boot/dts/renesas/r8a774b1-beacon-rzg2n-kit.dtb
arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77950-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77950-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77951-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77951-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77960-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77960-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77960-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77960-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77961-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77961-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77961-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77965-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a77965-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77995-draak.dtb
arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a779m1-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a779m1-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a779m3-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a779m3-ulcb.dtb
arch/arm64/boot/dts/renesas/r8a779m3-ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a779m5-salvator-xs.dtb
sound@ec500000: Unevaluated properties are not allowed ('port' was
unexpected)
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-mipi-2.1.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2-ex-idk-1110wr.dtb
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2-ex.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-ex.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-ex-idk-1110wr.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-ex-mipi-2.1.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex.dtb
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb
arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dtb
arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex.dtb
arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-idk-1110wr.dtb
arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-mipi-2.1.dtb
From schema: bindings/sound/renesas,rsnd.yaml
Signed-off-by: Michał Grzelak <mchl.grzlk@gmail.com>
---
.../bindings/sound/audio-graph-port.yaml | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
index f5b8b6d13077..4238128eb52e 100644
--- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
+++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
@@ -19,11 +19,11 @@ properties:
description: "device name prefix"
$ref: /schemas/types.yaml#/definitions/string
convert-rate:
- $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-sample-rate"
+ $ref: /schemas/sound/dai-params.yaml#/$defs/dai-sample-rate
convert-channels:
- $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-channels"
+ $ref: /schemas/sound/dai-params.yaml#/$defs/dai-channels
convert-sample-format:
- $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-sample-format"
+ $ref: /schemas/sound/dai-params.yaml#/$defs/dai-sample-format
patternProperties:
"^endpoint(@[0-9a-f]+)?":
@@ -67,12 +67,16 @@ patternProperties:
- pdm
- msb
- lsb
+ playback:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ capture:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
convert-rate:
- $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-sample-rate"
+ $ref: /schemas/sound/dai-params.yaml#/$defs/dai-sample-rate
convert-channels:
- $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-channels"
+ $ref: /schemas/sound/dai-params.yaml#/$defs/dai-channels
convert-sample-format:
- $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-sample-format"
+ $ref: /schemas/sound/dai-params.yaml#/$defs/dai-sample-format
dai-tdm-slot-num:
description: Number of slots in use.
--
2.37.3
next reply other threads:[~2023-01-20 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 1:17 Michał Grzelak [this message]
2023-01-20 4:38 ` Kuninori Morimoto
2023-01-20 22:49 ` Michał Grzelak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230120011744.550701-1-mchl.grzlk@gmail.com \
--to=mchl.grzlk@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®