From: Mario Limonciello <mario.limonciello@amd.com>
To: Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] pinctrl: amd: Fix debug output for debounce time
Date: Sat, 21 Jan 2023 07:48:10 -0600 [thread overview]
Message-ID: <20230121134812.16637-2-mario.limonciello@amd.com> (raw)
In-Reply-To: <20230121134812.16637-1-mario.limonciello@amd.com>
If one GPIO has debounce enabled but future GPIOs in the list don't
have debounce the time never gets reset and shows wrong value.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/pinctrl/pinctrl-amd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 9bc6e3922e78e..32c3edaf90385 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -365,6 +365,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
} else {
debounce_enable = " ∅";
+ time = 0;
}
snprintf(debounce_value, sizeof(debounce_value), "%u", time * unit);
seq_printf(s, "debounce %s (🕑 %sus)| ", debounce_enable, debounce_value);
--
2.34.1
next prev parent reply other threads:[~2023-01-21 13:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 13:48 [PATCH 0/2] Fix some more fallout from GPIOs from _CRS Mario Limonciello
2023-01-21 13:48 ` Mario Limonciello [this message]
2023-01-27 12:40 ` [PATCH 1/2] pinctrl: amd: Fix debug output for debounce time Linus Walleij
2023-01-21 13:48 ` [PATCH 2/2] gpiolib-acpi: Don't set GPIOs for wakeup in S3 mode Mario Limonciello
2023-01-23 12:23 ` Andy Shevchenko
2023-01-23 15:02 ` Bartosz Golaszewski
2023-01-23 15:55 ` Raul Rangel
2023-01-23 16:06 ` Limonciello, Mario
2023-01-23 16:34 ` Raul Rangel
2023-01-23 17:33 ` Andy Shevchenko
2023-01-23 17:30 ` Andy Shevchenko
2023-01-23 17:54 ` Raul Rangel
2023-01-23 18:21 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230121134812.16637-2-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®