From: Alex Williamson <alex.williamson@redhat.com>
To: Angus Chen <angus.chen@jaguarmicro.com>
Cc: eric.auger@redhat.com, cohuck@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: platform: No need to check res again
Date: Mon, 23 Jan 2023 12:36:58 -0700 [thread overview]
Message-ID: <20230123123658.2748e6fc.alex.williamson@redhat.com> (raw)
In-Reply-To: <20230107034721.2127-1-angus.chen@jaguarmicro.com>
On Sat, 7 Jan 2023 11:47:20 +0800
Angus Chen <angus.chen@jaguarmicro.com> wrote:
> In function vfio_platform_regions_init(),we did check res implied
> by using while loop,
> so no need to check whether res be null or not again.
>
> No functional change intended.
>
> Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> ---
> drivers/vfio/platform/vfio_platform_common.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> index 1a0a238ffa35..a9ad3f4d2613 100644
> --- a/drivers/vfio/platform/vfio_platform_common.c
> +++ b/drivers/vfio/platform/vfio_platform_common.c
> @@ -150,9 +150,6 @@ static int vfio_platform_regions_init(struct vfio_platform_device *vdev)
> struct resource *res =
> vdev->get_resource(vdev, i);
>
> - if (!res)
> - goto err;
> -
> vdev->regions[i].addr = res->start;
> vdev->regions[i].size = resource_size(res);
> vdev->regions[i].flags = 0;
Applied to vfio next branch for v6.3. Thanks,
Alex
prev parent reply other threads:[~2023-01-23 19:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 3:47 Angus Chen
2023-01-16 20:37 ` Eric Auger
2023-01-23 19:36 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123123658.2748e6fc.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=angus.chen@jaguarmicro.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®