From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF1B7C54EAA for ; Mon, 23 Jan 2023 06:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230131AbjAWGNF (ORCPT ); Mon, 23 Jan 2023 01:13:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjAWGND (ORCPT ); Mon, 23 Jan 2023 01:13:03 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1097166F8 for ; Sun, 22 Jan 2023 22:13:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674454380; x=1705990380; h=date:from:to:cc:subject:message-id:mime-version; bh=ZrWlA7H9Ck/EEmXSyxgR4L2s318DLrUa/Nclrn+qcGE=; b=T2b5dG5FEy9Lw3DqDTXzehDPRnJMKV0UeKuZipo5expjtkfUEK3xUxbY VHyHvkKs6Yad7iGmosnXKiNdLDPNaufxqWkDS4STJKgaZIUZGqbcDv68i F341rkbuDoH/I222/QGl64MFKvLP+7AWsCCkRiDtV2isAqQ5fGMMJRveW LInknTHijSAZ5mKXZK0mb+6rAWtBp/LBLtVxant+8hlGava2w1/88V4UO ZMQ2goNb53ci9h2F2nHDq8OBOtB7VEfE0Hf8TcBbnNC9ws1SoZGmbfZPx 3+n+Ukti6tLkpsx7bf5JzW119TKaPYyMVrcD4HQq1lQNrdwAghYI8c49u Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="412206674" X-IronPort-AV: E=Sophos;i="5.97,238,1669104000"; d="scan'208";a="412206674" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2023 22:13:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="639022736" X-IronPort-AV: E=Sophos;i="5.97,238,1669104000"; d="scan'208";a="639022736" Received: from lkp-server01.sh.intel.com (HELO 5646d64e7320) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 22 Jan 2023 22:12:59 -0800 Received: from kbuild by 5646d64e7320 with local (Exim 4.96) (envelope-from ) id 1pJq4g-0005Sz-10; Mon, 23 Jan 2023 06:12:58 +0000 Date: Mon, 23 Jan 2023 14:12:18 +0800 From: kernel test robot To: Li Zhengyu Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Palmer Dabbelt Subject: arch/riscv/kernel/elf_kexec.c:185:23: warning: variable 'kernel_start' set but not used Message-ID: <202301231434.xj7PQdW1-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Li, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 2475bf0250dee99b477e0c56d7dc9d7ac3f04117 commit: 838b3e28488f702e2b5477b393f009b2639d2b1a RISC-V: Load purgatory in kexec_file date: 8 months ago config: riscv-randconfig-r033-20230123 (https://download.01.org/0day-ci/archive/20230123/202301231434.xj7PQdW1-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=838b3e28488f702e2b5477b393f009b2639d2b1a git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 838b3e28488f702e2b5477b393f009b2639d2b1a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All warnings (new ones prefixed by >>): arch/riscv/kernel/elf_kexec.c: In function 'elf_kexec_load': >> arch/riscv/kernel/elf_kexec.c:185:23: warning: variable 'kernel_start' set but not used [-Wunused-but-set-variable] 185 | unsigned long kernel_start; | ^~~~~~~~~~~~ vim +/kernel_start +185 arch/riscv/kernel/elf_kexec.c 174 175 static void *elf_kexec_load(struct kimage *image, char *kernel_buf, 176 unsigned long kernel_len, char *initrd, 177 unsigned long initrd_len, char *cmdline, 178 unsigned long cmdline_len) 179 { 180 int ret; 181 unsigned long old_kernel_pbase = ULONG_MAX; 182 unsigned long new_kernel_pbase = 0UL; 183 unsigned long initrd_pbase = 0UL; 184 unsigned long headers_sz; > 185 unsigned long kernel_start; 186 void *fdt, *headers; 187 struct elfhdr ehdr; 188 struct kexec_buf kbuf; 189 struct kexec_elf_info elf_info; 190 char *modified_cmdline = NULL; 191 192 ret = kexec_build_elf_info(kernel_buf, kernel_len, &ehdr, &elf_info); 193 if (ret) 194 return ERR_PTR(ret); 195 196 ret = elf_find_pbase(image, kernel_len, &ehdr, &elf_info, 197 &old_kernel_pbase, &new_kernel_pbase); 198 if (ret) 199 goto out; 200 kernel_start = image->start; 201 pr_notice("The entry point of kernel at 0x%lx\n", image->start); 202 203 /* Add the kernel binary to the image */ 204 ret = riscv_kexec_elf_load(image, &ehdr, &elf_info, 205 old_kernel_pbase, new_kernel_pbase); 206 if (ret) 207 goto out; 208 209 kbuf.image = image; 210 kbuf.buf_min = new_kernel_pbase + kernel_len; 211 kbuf.buf_max = ULONG_MAX; 212 213 /* Add elfcorehdr */ 214 if (image->type == KEXEC_TYPE_CRASH) { 215 ret = prepare_elf_headers(&headers, &headers_sz); 216 if (ret) { 217 pr_err("Preparing elf core header failed\n"); 218 goto out; 219 } 220 221 kbuf.buffer = headers; 222 kbuf.bufsz = headers_sz; 223 kbuf.mem = KEXEC_BUF_MEM_UNKNOWN; 224 kbuf.memsz = headers_sz; 225 kbuf.buf_align = ELF_CORE_HEADER_ALIGN; 226 kbuf.top_down = true; 227 228 ret = kexec_add_buffer(&kbuf); 229 if (ret) { 230 vfree(headers); 231 goto out; 232 } 233 image->elf_headers = headers; 234 image->elf_load_addr = kbuf.mem; 235 image->elf_headers_sz = headers_sz; 236 237 pr_debug("Loaded elf core header at 0x%lx bufsz=0x%lx memsz=0x%lx\n", 238 image->elf_load_addr, kbuf.bufsz, kbuf.memsz); 239 240 /* Setup cmdline for kdump kernel case */ 241 modified_cmdline = setup_kdump_cmdline(image, cmdline, 242 cmdline_len); 243 if (!modified_cmdline) { 244 pr_err("Setting up cmdline for kdump kernel failed\n"); 245 ret = -EINVAL; 246 goto out; 247 } 248 cmdline = modified_cmdline; 249 } 250 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests