From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: linux-nvme@lists.infradead.org, "Christoph Hellwig" <hch@lst.de>,
"Keith Busch" <kbusch@kernel.org>,
"Chaitanya Kulkarni" <kch@nvidia.com>,
"Gerd Bayer" <gbayer@linux.ibm.com>,
"Sagi Grimberg" <sagi@grimberg.me>, "Jens Axboe" <axboe@fb.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH] nvme-pci: Switch back to sync probe to fix rootfs mount regression
Date: Tue, 24 Jan 2023 02:45:42 +0200 [thread overview]
Message-ID: <20230124004542.29659-1-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Async probe caused a regression where we fail to find the
rootfs in time, leading an unbootable machine.
rootdelay=1 can be used as a workaround but that needlessly
slows down the boot by a whole extra second.
To get the best of both worlds perhaps there should be
some kind of async probe flush/sync just before attempting
to mount the rootfs?
In the meantime just switch back to a sync probe to fix
the regression.
Cc: linux-nvme@lists.infradead.org
Cc: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Chaitanya Kulkarni <kch@nvidia.com>
Cc: Gerd Bayer <gbayer@linux.ibm.com>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@fb.com>
Fixes: eac3ef262941 ("nvme-pci: split the initial probe from the rest path")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/nvme/host/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 1ff8843bc4b3..d0f5e93d977e 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3514,7 +3514,6 @@ static struct pci_driver nvme_driver = {
.remove = nvme_remove,
.shutdown = nvme_shutdown,
.driver = {
- .probe_type = PROBE_PREFER_ASYNCHRONOUS,
#ifdef CONFIG_PM_SLEEP
.pm = &nvme_dev_pm_ops,
#endif
--
2.39.1
next reply other threads:[~2023-01-24 0:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 0:45 Ville Syrjala [this message]
2023-01-24 6:21 ` Christoph Hellwig
2023-01-24 8:47 ` Ville Syrjälä
2023-01-24 13:41 ` Christoph Hellwig
2023-01-24 15:56 ` Keith Busch
2023-01-24 17:12 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124004542.29659-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=axboe@fb.com \
--cc=gbayer@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®