mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	chriscli@google.com
Subject: Re: [PATCH] ftrace: Show a list of all functions that have ever been enabled
Date: Tue, 24 Jan 2023 14:06:17 -0500	[thread overview]
Message-ID: <20230124140617.4a4fe106@gandalf.local.home> (raw)
In-Reply-To: <Y9AG63mgkyzSEbSa@FVFF77S0Q05N>

On Tue, 24 Jan 2023 16:27:23 +0000
Mark Rutland <mark.rutland@arm.com> wrote:

> > [
> >   This patch will conflict with Mark's patch that is going through the ARM
> >   tree. I will hold off pulling this patch until the next merge window, and
> >   rebase it on top of the changes when the tracing tree merges with upstream
> >   that has the changes from the ARM tree.
> > ]  
> 
> Sorry for the conflict!

No problem. This was more to help us debug something, and we are currently
just backporting it for now to our kernels in order to help with the
crashes we are seeing. No rush to get it upstream. But I figured that if it
can help us, it can also help others.

> 
> The patch looks good to me; I just gave it a spin on arm64 (resolving the
> conflcit with my changes by moving FTRCE_FL_TOUCHED to bit 20, and
> FTRACE_REF_MAX_SHIFT down to 20), and from a naive test that seems happy:
> 
> | # cat /sys/kernel/tracing/touched_functions 
> | # echo do_el0_svc > /sys/kernel/tracing/set_ftrace_filter 
> | # echo function_graph > /sys/kernel/tracing/current_tracer 
> | # cat /sys/kernel/tracing/touched_functions 
> | do_el0_svc (1)       O  ops: graph_ops+0x0/0xb8 (ftrace_graph_func+0x0/0x58)
> | # echo nop > /sys/kernel/tracing/current_tracer 
> | # cat /sys/kernel/tracing/touched_functions 
> | do_el0_svc (0) 

Thanks for testing! I guess I can add a "tested-by" from you?

-- Steve

  reply	other threads:[~2023-01-24 19:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24 14:56 Steven Rostedt
2023-01-24 16:27 ` Mark Rutland
2023-01-24 19:06   ` Steven Rostedt [this message]
2023-01-25  9:29     ` Mark Rutland
2023-01-25 22:53     ` Chris Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230124140617.4a4fe106@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=catalin.marinas@arm.com \
    --cc=chriscli@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®