mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Madalin Bucur <madalin.bucur@nxp.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH net-next] net: pcs: pcs-lynx: remove lynx_get_mdio_device() and refactor cleanup
Date: Fri, 27 Jan 2023 15:07:58 +0100	[thread overview]
Message-ID: <20230127150758.68eb1d29@pc-7.home> (raw)
In-Reply-To: <20230127134351.xlz4wqrubfnvmecd@skbuf>

Hi Vlad,

On Fri, 27 Jan 2023 15:43:51 +0200
Vladimir Oltean <vladimir.oltean@nxp.com> wrote:

> On Fri, Jan 27, 2023 at 02:40:30PM +0100, Maxime Chevallier wrote:
> > One of the main difference is that the TSE pcs is memory-mapped, and
> > the merge into pcs-lynx would first require a conversion of pcs-lynx
> > to regmap.  
> 
> I suppose sooner or later you'll want to convert stuff like
> phylink_mii_c22_pcs_get_state() to regmap too?

Well that was my next part to tackle indeed...

> Can't you create an MDIO bus for the TSE PCS which translates MDIO
> reads/writes to MMIO accesses?

TBH I haven't considered that, I guess this would definitely make thing
much easier. Since the register layout of the TSE PCS is very very
similar to the C22 layout, that could be indeed justified, as it's
basically a set of standard mdio registers exposed through mmio.

Thanks for the tip.

However this current patch still makes sense though right ?

Maxime

  reply	other threads:[~2023-01-27 14:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 13:40 Maxime Chevallier
2023-01-27 13:43 ` Vladimir Oltean
2023-01-27 14:07   ` Maxime Chevallier [this message]
2023-01-28  1:58     ` Vladimir Oltean
2023-01-30 18:14       ` Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230127150758.68eb1d29@pc-7.home \
    --to=maxime.chevallier@bootlin.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=madalin.bucur@nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®