From: Andrew Jones <ajones@ventanamicro.com>
To: Jinyu Tang <tjytimi@163.com>
Cc: palmer@rivosinc.com, paul.walmsley@sifive.com,
palmer@dabbelt.com, yuzhao@google.com,
conor.dooley@microchip.com, guoren@kernel.org,
tongtiangen@huawei.com, anup@brainfault.org,
akpm@linux-foundation.org, falcon@tinylab.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] riscv: support arch_has_hw_pte_young()
Date: Mon, 30 Jan 2023 09:22:39 +0100 [thread overview]
Message-ID: <20230130082239.xptbyeqskdczm6ns@orel> (raw)
In-Reply-To: <20230129064956.143664-1-tjytimi@163.com>
On Sun, Jan 29, 2023 at 02:49:56PM +0800, Jinyu Tang wrote:
> The arch_has_hw_pte_young() is false for riscv by default. If it's
> false, page table walk is almost skipped for MGLRU reclaim. And it
> will also cause useless step in __wp_page_copy_user().
>
> RISC-V Privileged Book says that riscv have two schemes to manage A
> and D bit.
>
> So add a config for selecting, the default is true. For simple
> implementation riscv CPU which just generate page fault, unselect it.
>
> Signed-off-by: Jinyu Tang <tjytimi@163.com>
> ---
> arch/riscv/Kconfig | 10 ++++++++++
> arch/riscv/include/asm/pgtable.h | 7 +++++++
> 2 files changed, 17 insertions(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index e2b656043abf..17c82885549c 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -180,6 +180,16 @@ config PAGE_OFFSET
> default 0x80000000 if 64BIT && !MMU
> default 0xff60000000000000 if 64BIT
>
> +config ARCH_HAS_HARDWARE_PTE_YOUNG
> + bool "Hardware Set PTE Access Bit"
> + default y
> + help
> + Select if hardware set A bit when PTE is accessed. The default is
> + 'Y', because most RISC-V CPU hardware can manage A and D bit.
> + But RISC-V may have simple implementation that do not support
> + hardware set A bit but only generate page fault, for that case just
> + unselect it.
> +
> config KASAN_SHADOW_OFFSET
> hex
> depends on KASAN_GENERIC
> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> index 4eba9a98d0e3..1db54ab4e1ba 100644
> --- a/arch/riscv/include/asm/pgtable.h
> +++ b/arch/riscv/include/asm/pgtable.h
> @@ -532,6 +532,13 @@ static inline int ptep_clear_flush_young(struct vm_area_struct *vma,
> */
> return ptep_test_and_clear_young(vma, address, ptep);
> }
> +#ifdef CONFIG_ARCH_HAS_HARDWARE_PTE_YOUNG
> +#define arch_has_hw_pte_young arch_has_hw_pte_young
> +static inline bool arch_has_hw_pte_young(void)
> +{
> + return true;
> +}
> +#endif
>
> #define pgprot_noncached pgprot_noncached
> static inline pgprot_t pgprot_noncached(pgprot_t _prot)
> --
> 2.30.2
>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Thanks,
drew
next prev parent reply other threads:[~2023-01-30 8:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 6:49 Jinyu Tang
2023-01-30 8:22 ` Andrew Jones [this message]
2023-01-30 10:14 ` Conor Dooley
2023-01-30 10:25 ` Anup Patel
2023-01-30 10:49 ` Andrew Jones
2023-01-30 17:27 ` Jessica Clarke
2023-08-25 5:42 ` Yong-Xuan Wang
2023-08-25 19:39 ` Alexandre Ghiti
2023-08-28 7:26 ` Yong-Xuan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130082239.xptbyeqskdczm6ns@orel \
--to=ajones@ventanamicro.com \
--cc=akpm@linux-foundation.org \
--cc=anup@brainfault.org \
--cc=conor.dooley@microchip.com \
--cc=falcon@tinylab.org \
--cc=guoren@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=tjytimi@163.com \
--cc=tongtiangen@huawei.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®