mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <ye.xingchen@zte.com.cn>
To: <jgg@ziepe.ca>
Cc: <rostedt@goodmis.org>, <akrowiak@linux.ibm.com>,
	<alex.williamson@redhat.com>, <alex.gaynor@gmail.com>,
	<ojeda@kernel.org>, <mhiramat@kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH] samples: fix the compile error about SAMPLE_VFIO_MDEV_ series
Date: Mon, 30 Jan 2023 16:55:03 +0800 (CST)	[thread overview]
Message-ID: <202301301655039458241@zte.com.cn> (raw)

From: ye xingchen <ye.xingchen@zte.com.cn>

When CONFIG_VFIO = m, SAMPLE_VFIO_MDEV_MTTY, SAMPLE_VFIO_MDEV_MTTY and
SAMPLE_VFIO_MDEV_MBOCHS can be selected as:
CONFIG_SAMPLE_VFIO_MDEV_MTTY = y;
CONFIG_SAMPLE_VFIO_MDEV_MTTY = y;
CONFIG_SAMPLE_VFIO_MDEV_MBOCHS = y;

That will cause compile error such as:

ld: samples/vfio-mdev/mdpy.o: in function 'mdpy_remove':
samples/vfio-mdev/mdpy.c:294: undefined reference to
'vfio_unregister_group_dev'

ld: samples/vfio-mdev/mtty.o: in function 'mtty_remove':
samples/vfio-mdev/mtty.c:793: undefined reference to
'vfio_unregister_group_dev'

ld: samples/vfio-mdev/mbochs.o: in function 'mbochs_remove':
samples/vfio-mdev/mbochs.c:603: undefined reference to
'vfio_unregister_group_dev'

Add dependency make SAMPLE_VFIO_MDEV_MTTY, SAMPLE_VFIO_MDEV_MTTY and
SAMPLE_VFIO_MDEV_MBOCHS not allowed to set as y when
CONFIG_VFIO = m.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 samples/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/samples/Kconfig b/samples/Kconfig
index 56b191d128d8..44a09dfa8a0b 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -185,6 +185,7 @@ config SAMPLE_UHID

 config SAMPLE_VFIO_MDEV_MTTY
 	tristate "Build VFIO mtty example mediated device sample code"
+	depends on VFIO
 	select VFIO_MDEV
 	help
 	  Build a virtual tty sample driver for use as a VFIO
@@ -192,6 +193,7 @@ config SAMPLE_VFIO_MDEV_MTTY

 config SAMPLE_VFIO_MDEV_MDPY
 	tristate "Build VFIO mdpy example mediated device sample code"
+	depends on VFIO
 	select VFIO_MDEV
 	help
 	  Build a virtual display sample driver for use as a VFIO
@@ -209,6 +211,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB

 config SAMPLE_VFIO_MDEV_MBOCHS
 	tristate "Build VFIO mdpy example mediated device sample code"
+	depends on VFIO
 	select VFIO_MDEV
 	select DMA_SHARED_BUFFER
 	help
-- 
2.25.1

             reply	other threads:[~2023-01-30  8:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30  8:55 ye.xingchen [this message]
2023-01-30 23:55 ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202301301655039458241@zte.com.cn \
    --to=ye.xingchen@zte.com.cn \
    --cc=akrowiak@linux.ibm.com \
    --cc=alex.gaynor@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®