From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 1/9] staging: r8188eu: rtw_free_xmitframe_queue needs no spinlock
Date: Mon, 30 Jan 2023 20:52:55 +0100 [thread overview]
Message-ID: <20230130195303.138941-2-martin@kaiser.cx> (raw)
In-Reply-To: <20230130195303.138941-1-martin@kaiser.cx>
There's no need for a spinlock in rtw_free_xmitframe_queue.
This function is called only from rtw_free_stainfo. rtw_free_stainfo holds
pxmitpriv->lock during all rtw_free_xmitframe_queue calls.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_xmit.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c
index f50e10f0d51f..4e49f1d49eb5 100644
--- a/drivers/staging/r8188eu/core/rtw_xmit.c
+++ b/drivers/staging/r8188eu/core/rtw_xmit.c
@@ -1330,8 +1330,6 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue *pfram
struct list_head *plist, *phead;
struct xmit_frame *pxmitframe;
- spin_lock_bh(&pframequeue->lock);
-
phead = get_list_head(pframequeue);
plist = phead->next;
@@ -1342,7 +1340,6 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue *pfram
rtw_free_xmitframe(pxmitpriv, pxmitframe);
}
- spin_unlock_bh(&pframequeue->lock);
}
struct xmit_frame *rtw_dequeue_xframe(struct xmit_priv *pxmitpriv, struct hw_xmit *phwxmit_i)
--
2.30.2
next prev parent reply other threads:[~2023-01-30 19:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 19:52 [PATCH 0/9] staging: r8188eu: another round of xmit cleanups Martin Kaiser
2023-01-30 19:52 ` Martin Kaiser [this message]
2023-01-30 19:52 ` [PATCH 2/9] staging: r8188eu: change function param from __queue to list_head Martin Kaiser
2023-01-30 19:52 ` [PATCH 3/9] staging: r8188eu: change another " Martin Kaiser
2023-01-30 19:52 ` [PATCH 4/9] staging: r8188eu: make sta_pending a list_head Martin Kaiser
2023-01-30 19:52 ` [PATCH 5/9] staging: r8188eu: use kernel helper to iterate over a list Martin Kaiser
2023-01-30 19:53 ` [PATCH 6/9] staging: r8188eu: legacy_dz is initialised but never used Martin Kaiser
2023-01-30 19:53 ` [PATCH 7/9] staging: r8188eu: apsd " Martin Kaiser
2023-01-30 19:53 ` [PATCH 8/9] staging: r8188eu: option in struct sta_xmit_priv is not used Martin Kaiser
2023-01-30 19:53 ` [PATCH 9/9] staging: r8188eu: replace switch-case with if Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130195303.138941-2-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®