mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Jeff Xie <xiehuan09@gmail.com>
Cc: mingo@redhat.com, mhiramat@kernel.org, zanussi@kernel.org,
	linux-kernel@vger.kernel.org, chensong_2000@189.cn
Subject: Re: [PATCH v15 0/4] trace: Introduce objtrace trigger to trace the kernel object
Date: Tue, 31 Jan 2023 10:36:23 -0500	[thread overview]
Message-ID: <20230131103623.53a4e3a3@gandalf.local.home> (raw)
In-Reply-To: <CAEr6+EB89otsHVOnYNGQ_gbo_g=2fNiU4+3pk06YWFrpZDy=kQ@mail.gmail.com>

On Tue, 31 Jan 2023 17:55:16 +0800
Jeff Xie <xiehuan09@gmail.com> wrote:

>  Hi Steve,
> 
> On Sat, Dec 17, 2022 at 4:27 PM Jeff Xie <xiehuan09@gmail.com> wrote:
> >
> > On Wed, Nov 30, 2022 at 12:30 AM Steven Rostedt <rostedt@goodmis.org> wrote:  
> > >
> > > On Wed, 30 Nov 2022 00:09:51 +0800
> > > Jeff Xie <xiehuan09@gmail.com> wrote:
> > >  
> > > > > Now instead of searching the function arguments for "obj", we should just
> > > > > read the obj value at every function and report when it changed, as well as
> > > > > the last function it was still the same. The report will be like the
> > > > > "func_repeats" entry. And instead we can print when the object changes,
> > > > > something like this:
> > > > >
> > > > >               cat-117     [002] ...2.     1.602245: bio_add_page <-ext4_mpage_readpages object:0xffff88811bee4000 value:0x2000 (last value:0x1000 at [002] __bio_add_page <-bio_add_page ts: 1.602245)  
> > > >
> > > >
> > > > I'm just curious if we'll see this rewritten version in the next merge
> > > > window  ;-)  
> > >
> > > Unfortunately, this ended up getting dropped in priority, as my workload
> > > increased internally. :-/  
> >  
> 
> I would like to ask if there is any hope that this patchset can be
> merged into the linux kernel in the end.
> 
> We spent a lot of time on this patchset, I don't want to give up so easily ;-)
> 

I think we were near the end, but it wasn't quite done, as I want it to be
integrated with the kprobes indirection interface:

  https://lore.kernel.org/all/20220924160136.5029e942@rorschach.local.home/

Which I started to work on but didn't have time to finish, nor even get
very far with it.

I think once we can get that implemented, then this can get in. I don't
want to give up on it either.

-- Steve

  reply	other threads:[~2023-01-31 15:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19  3:27 Jeff Xie
2022-08-19  3:27 ` [PATCH v15 1/4] trace: Add trace any " Jeff Xie
2022-10-17 19:58   ` Steven Rostedt
2022-10-18  8:35     ` Jeff Xie
2022-08-19  3:27 ` [PATCH v15 2/4] trace/objtrace: Get the value of the object Jeff Xie
2022-09-24 20:01   ` Steven Rostedt
2022-09-25  5:27     ` Jeff Xie
2022-09-25 15:53       ` Steven Rostedt
2022-09-25 16:49         ` Jeff Xie
2022-09-28 14:15           ` Jeff Xie
2022-09-28 14:40             ` Steven Rostedt
2022-08-19  3:27 ` [PATCH v15 3/4] selftests/ftrace: Add testcases for objtrace Jeff Xie
2022-08-19  3:27 ` [PATCH v15 4/4] Documentation: trace/objtrace: Add documentation " Jeff Xie
2022-10-17 19:40 ` [PATCH v15 0/4] trace: Introduce objtrace trigger to trace the kernel object Steven Rostedt
2022-10-18  7:01   ` Jeff Xie
2022-11-29 16:09   ` Jeff Xie
2022-11-29 16:30     ` Steven Rostedt
2022-12-17  8:27       ` Jeff Xie
2023-01-31  9:55         ` Jeff Xie
2023-01-31 15:36           ` Steven Rostedt [this message]
2023-01-31 15:48             ` Jeff Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230131103623.53a4e3a3@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=chensong_2000@189.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=xiehuan09@gmail.com \
    --cc=zanussi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®