From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA52C636D7 for ; Tue, 31 Jan 2023 15:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232767AbjAaPEj (ORCPT ); Tue, 31 Jan 2023 10:04:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232866AbjAaPEI (ORCPT ); Tue, 31 Jan 2023 10:04:08 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 079BF564A6; Tue, 31 Jan 2023 07:01:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0442961568; Tue, 31 Jan 2023 15:01:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1950C433D2; Tue, 31 Jan 2023 15:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675177273; bh=r0nnX5U1+BUG48iTx+I5+ENJefltBEQkUIe5IxLejBQ=; h=From:To:Cc:Subject:Date:From; b=NbKIxLdtaPNFCvIGs8RBzlk5Sz7Jjt6OKWZkhl4oZge05JnmyncR3qrTjrmmyXIzi HU4PHFKAaijdihzLVevUQppbghjAwd2y5LHeaK3Sid+Hv1OBfQTs2KVtWemZryBQIv M+hFkoC/Yx9LAeXJGOzgCR4ChPYBfX4CH4OyNxl0ofisBdkiO7PS2iFSH3LWvixloO d/n6HVfX37Mx3rED1sbKQHWsfw+xzOBJEu6exPJwDAGbL+Ak3z19nqOA1rYhSe6nJJ qrfPg5WSBginmXMXY/vRejsZPu1YepZoo2eq/uYrd1BuFVhyXDbMV0mn92vNQtrdja nYmmiHdF1Hx3A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Maurizio Lombardi , Christoph Hellwig , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 1/4] scsi: target: core: Fix warning on RT kernels Date: Tue, 31 Jan 2023 10:01:07 -0500 Message-Id: <20230131150110.1250351-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maurizio Lombardi [ Upstream commit 84ed64b1a7a7fcd507598dee7708c1f225123711 ] Calling spin_lock_irqsave() does not disable the interrupts on realtime kernels, remove the warning and replace assert_spin_locked() with lockdep_assert_held(). Signed-off-by: Maurizio Lombardi Reviewed-by: Christoph Hellwig Link: https://lore.kernel.org/r/20230110125310.55884-1-mlombard@redhat.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_tmr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_tmr.c b/drivers/target/target_core_tmr.c index feeba3966617..6928ebf0be9c 100644 --- a/drivers/target/target_core_tmr.c +++ b/drivers/target/target_core_tmr.c @@ -82,8 +82,8 @@ static bool __target_check_io_state(struct se_cmd *se_cmd, { struct se_session *sess = se_cmd->se_sess; - assert_spin_locked(&sess->sess_cmd_lock); - WARN_ON_ONCE(!irqs_disabled()); + lockdep_assert_held(&sess->sess_cmd_lock); + /* * If command already reached CMD_T_COMPLETE state within * target_complete_cmd() or CMD_T_FABRIC_STOP due to shutdown, -- 2.39.0