From: Stephen Hemminger <stephen@networkplumber.org>
To: Pietro Borrello <borrello@diag.uniroma1.it>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Lorenzo Colitti <lorenzo@google.com>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>, Jakob Koschel <jkl820.git@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] tun: tun_chr_open(): correctly initialize socket uid
Date: Tue, 31 Jan 2023 19:10:55 -0800 [thread overview]
Message-ID: <20230131191055.45bb4ab7@hermes.local> (raw)
In-Reply-To: <20230131-tuntap-sk-uid-v1-1-af4f9f40979d@diag.uniroma1.it>
On Wed, 01 Feb 2023 00:35:45 +0000
Pietro Borrello <borrello@diag.uniroma1.it> wrote:
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index a7d17c680f4a..6713fffb1488 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -3450,6 +3450,11 @@ static int tun_chr_open(struct inode *inode, struct file * file)
>
> sock_init_data(&tfile->socket, &tfile->sk);
>
> + // sock_init_data initializes sk.sk_uid assuming tfile->socket is embedded
> + // in a struct socket_alloc and reading its corresponding inode. Since we
> + // pass a socket contained in a struct tun_file we have to fix this manually
> + tfile->sk.sk_uid = inode->i_uid;
> +
Do not use C++ style comments in the kernel.
Rule #1 of code maintenance. Bug fixes should not stand out.
next prev parent reply other threads:[~2023-02-01 3:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 0:35 [PATCH net-next 0/2] tuntap: " Pietro Borrello
2023-02-01 0:35 ` [PATCH net-next 1/2] tun: tun_chr_open(): " Pietro Borrello
2023-02-01 3:10 ` Stephen Hemminger [this message]
2023-02-01 11:01 ` Pietro Borrello
2023-02-01 0:35 ` [PATCH net-next 2/2] tap: tap_open(): " Pietro Borrello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131191055.45bb4ab7@hermes.local \
--to=stephen@networkplumber.org \
--cc=borrello@diag.uniroma1.it \
--cc=c.giuffrida@vu.nl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=h.j.bos@vu.nl \
--cc=jkl820.git@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome