From: "D. Starke" <daniel.starke@siemens.com>
To: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: linux-kernel@vger.kernel.org, Daniel Starke <daniel.starke@siemens.com>
Subject: [PATCH 3/3] tty: n_gsm: add TIOCMIWAIT support
Date: Wed, 1 Feb 2023 09:01:51 +0100 [thread overview]
Message-ID: <20230201080151.2068-3-daniel.starke@siemens.com> (raw)
In-Reply-To: <20230201080151.2068-1-daniel.starke@siemens.com>
From: Daniel Starke <daniel.starke@siemens.com>
Add support for the TIOCMIWAIT ioctl on the virtual ttys. This enables the
user to wait for virtual modem signals like RING.
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
---
drivers/tty/n_gsm.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 118511c1fa37..48fb7dad44cd 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1542,6 +1542,7 @@ static void gsm_process_modem(struct tty_struct *tty, struct gsm_dlci *dlci,
if (brk & 0x01)
tty_insert_flip_char(&dlci->port, 0, TTY_BREAK);
dlci->modem_rx = mlines;
+ wake_up_interruptible(&dlci->gsm->event);
}
/**
@@ -3848,6 +3849,35 @@ static int gsm_modem_update(struct gsm_dlci *dlci, u8 brk)
return -EPROTONOSUPPORT;
}
+/**
+ * gsm_wait_modem_change - wait for modem status line change
+ * @dlci: channel
+ * @mask: modem status line bits
+ */
+
+static int gsm_wait_modem_change(struct gsm_dlci *dlci, u32 mask)
+{
+ struct gsm_mux *gsm = dlci->gsm;
+ u32 old = dlci->modem_rx & mask;
+ int ret;
+
+ if (gsm->dead)
+ return -ENODEV;
+
+ do {
+ ret = wait_event_interruptible(gsm->event, gsm->dead
+ || old ^ (dlci->modem_rx & mask));
+ if (ret)
+ return ret;
+ if (dlci->state != DLCI_OPEN)
+ return -EL2NSYNC;
+ if (gsm->dead)
+ return -ENODEV;
+ } while ((old ^ (dlci->modem_rx & mask)) == 0);
+
+ return 0;
+}
+
static bool gsm_carrier_raised(struct tty_port *port)
{
struct gsm_dlci *dlci = container_of(port, struct gsm_dlci, port);
@@ -4107,6 +4137,8 @@ static int gsmtty_ioctl(struct tty_struct *tty,
gsm_destroy_network(dlci);
mutex_unlock(&dlci->mutex);
return 0;
+ case TIOCMIWAIT:
+ return gsm_wait_modem_change(dlci, arg);
default:
return -ENOIOCTLCMD;
}
--
2.34.1
next prev parent reply other threads:[~2023-02-01 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 8:01 [PATCH 1/3] tty: n_gsm: add keep alive support D. Starke
2023-02-01 8:01 ` [PATCH 2/3] tty: n_gsm: add RING/CD control support D. Starke
2023-02-01 8:01 ` D. Starke [this message]
2023-02-01 8:41 ` [PATCH 3/3] tty: n_gsm: add TIOCMIWAIT support Greg KH
2023-02-01 9:30 ` Starke, Daniel
2023-02-01 12:51 ` Greg KH
2023-02-01 8:40 ` [PATCH 1/3] tty: n_gsm: add keep alive support Greg KH
2023-02-01 9:17 ` Starke, Daniel
2023-02-01 9:27 ` Greg KH
2023-02-01 9:48 ` Starke, Daniel
2023-02-01 12:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201080151.2068-3-daniel.starke@siemens.com \
--to=daniel.starke@siemens.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®